Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Issue 2065843003: Remove transform feedback validation in Blink (Closed)

Created:
4 years, 6 months ago by qiankun
Modified:
4 years, 6 months ago
CC:
chromium-reviews, blink-reviews, piman+watch_chromium.org, haraken
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove transform feedback validation in Blink These validations have been moved to command buffer. BUG=295792 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/a6c129b2ccf0a7e1c75638bb6c9432d5f638b546 Cr-Commit-Position: refs/heads/master@{#400373}

Patch Set 1 #

Patch Set 2 : fix transform feedback status query #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -130 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 2 chunks +19 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp View 11 chunks +2 lines, -92 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp View 2 chunks +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLTransformFeedback.h View 2 chunks +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLTransformFeedback.cpp View 2 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
qiankun
PTAL. Code cleanup.
4 years, 6 months ago (2016-06-15 10:58:10 UTC) #4
Zhenyao Mo
On 2016/06/15 10:58:10, qiankun wrote: > PTAL. Code cleanup. lgtm
4 years, 6 months ago (2016-06-15 16:32:55 UTC) #5
Ken Russell (switch to Gerrit)
Excellent. Thank you Qiankun for doing this cleanup. LGTM
4 years, 6 months ago (2016-06-15 18:39:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065843003/20001
4 years, 6 months ago (2016-06-16 01:20:11 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_rel/builds/128096)
4 years, 6 months ago (2016-06-16 02:42:05 UTC) #10
qiankun
Don't know what happened. It passed on mac_optional_gpu_tests_rel yesterday. I didn't change anything. And I ...
4 years, 6 months ago (2016-06-16 12:32:56 UTC) #11
Zhenyao Mo
On 2016/06/16 12:32:56, qiankun wrote: > Don't know what happened. It passed on mac_optional_gpu_tests_rel yesterday. ...
4 years, 6 months ago (2016-06-16 19:27:49 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065843003/20001
4 years, 6 months ago (2016-06-17 04:18:55 UTC) #14
qiankun
On 2016/06/16 19:27:49, Zhenyao Mo wrote: > On 2016/06/16 12:32:56, qiankun wrote: > > Don't ...
4 years, 6 months ago (2016-06-17 04:19:13 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-17 05:53:50 UTC) #16
commit-bot: I haz the power
4 years, 6 months ago (2016-06-17 05:55:12 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a6c129b2ccf0a7e1c75638bb6c9432d5f638b546
Cr-Commit-Position: refs/heads/master@{#400373}

Powered by Google App Engine
This is Rietveld 408576698