Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 2065833003: Introduce EmbedderHeapTracer::EnterFinalPause() (Closed)

Created:
4 years, 6 months ago by Marcel Hlopko
Modified:
4 years, 6 months ago
CC:
Hannes Payer (out of office), Paweł Hajdan Jr., ulan, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Introduce EmbedderHeapTracer::EnterFinalPause() I need this method because of ActiveScriptWrappables, which have to be processed at the atomic pause even for incremental solution, as there is no other way of detecting when an object starts or stops being active than querying it. LOG=no BUG=468240 Committed: https://crrev.com/eaafd900e9dbe1e82cd4d690db7434be76606dac Cr-Commit-Position: refs/heads/master@{#37062}

Patch Set 1 #

Patch Set 2 : Move to a correct place #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M include/v8.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/heap/mark-compact.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Marcel Hlopko
Ptal.
4 years, 6 months ago (2016-06-14 14:06:29 UTC) #2
ulan
lgtm
4 years, 6 months ago (2016-06-17 09:53:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065833003/20001
4 years, 6 months ago (2016-06-17 09:54:25 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-17 10:25:16 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-17 10:25:53 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/eaafd900e9dbe1e82cd4d690db7434be76606dac
Cr-Commit-Position: refs/heads/master@{#37062}

Powered by Google App Engine
This is Rietveld 408576698