Add 'address' vm service message that finds heap objects.

runtime/vm/heap.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/heap.h"
 
 #include "platform/assert.h"
 #include "platform/utils.h"
 #include "vm/flags.h"
 #include "vm/isolate.h"
@@ skipping 144 matching lines @@
 void Heap::IterateNewObjects(ObjectVisitor* visitor) {
   new_space_->VisitObjects(visitor);
 }
 
 
 void Heap::IterateOldObjects(ObjectVisitor* visitor) {
   old_space_->VisitObjects(visitor);
 }
 
 
-RawInstructions* Heap::FindObjectInCodeSpace(FindObjectVisitor* visitor) {
+RawInstructions* Heap::FindObjectInCodeSpace(FindObjectVisitor* visitor) const {
   // Only executable pages can have RawInstructions objects.
   RawObject* raw_obj = old_space_->FindObject(visitor, HeapPage::kExecutable);
   ASSERT((raw_obj == Object::null()) ||
          (raw_obj->GetClassId() == kInstructionsCid));
   return reinterpret_cast<RawInstructions*>(raw_obj);
 }
 
 
 RawObject* Heap::FindOldObject(FindObjectVisitor* visitor) const {
   return old_space_->FindObject(visitor, HeapPage::kData);
 }
 
 
+RawObject* Heap::FindNewObject(FindObjectVisitor* visitor) const {
+  return new_space_->FindObject(visitor);
+}
+
+
+RawObject* Heap::FindObject(FindObjectVisitor* visitor) const {
+  ASSERT(Isolate::Current()->no_gc_scope_depth() != 0);
+  RawObject* raw_obj = FindNewObject(visitor);
+  if (raw_obj != Object::null()) {
+    return raw_obj;
+  }
+  raw_obj = FindOldObject(visitor);
+  if (raw_obj != Object::null()) {
+    return raw_obj;
+  }
+  raw_obj = FindObjectInCodeSpace(visitor);
+  return raw_obj;
+}

[turnidge, 2014/03/20 17:01:19]

This code does get tested by service_test.cc, but you might consider adding a
more direct unit test in heap_test.cc.  Up to you.

[koda, 2014/03/20 20:25:37]

Done.

+
+
 void Heap::CollectGarbage(Space space, ApiCallbacks api_callbacks) {
   Isolate* isolate = Isolate::Current();
   bool invoke_api_callbacks = (api_callbacks == kInvokeApiCallbacks);
   switch (space) {
     case kNew: {
       VMTagScope tagScope(isolate, VMTag::kGCNewSpaceTagId);
       RecordBeforeGC(kNew, kNewSpace);
       UpdateClassHeapStatsBeforeGC(kNew);
       new_space_->Scavenge(invoke_api_callbacks);
       RecordAfterGC();
@@ skipping 363 matching lines @@
     heap->DisableGrowthControl();
 }
 
 
 NoHeapGrowthControlScope::~NoHeapGrowthControlScope() {
     Heap* heap = reinterpret_cast<Isolate*>(isolate())->heap();
     heap->SetGrowthControlState(current_growth_controller_state_);
 }
 
 }  // namespace dart