Fix for sync filesystem app crash.

Fix for sync filesystem app crash.

Previously removing the SafePointScope had a risk of producing a dead lock if the following scenario happens:

1) The main thread starts a GC and tries to stop all other threads.
2) The worker thread is waiting on a signal without entering the SafePointScope. The main thread cannot stop the worker thread forever and thus cannot make progress. Dead lock.

However, (to avoid this kind of dead lock) code has been added to timeout the GC if the GCing thread fails at stopping other threads within 100 ms. So not entering SafePointScope will just cause the timeout -- it won't cause a dead lock.

This fixes a hard-to-reproduce timing bug that's been a big concern of one of our partners.

BUG=592124, 608603
TEST=manual

Review-Url: https://codereview.chromium.org/2009093002
Cr-Commit-Position: refs/heads/master@{#399265}
(cherry picked from commit f466a07e32ce1c8083dc726c7391e68b2ff2e7b0)

Committed: https://chromium.googlesource.com/chromium/src/+/d023da3f77306882389a2d8a09a7125815a00b31

[achuithb, 2016-06-14 19:44:52]

Description was changed from

==========
Fix for sync filesystem app crash.

Previously removing the SafePointScope had a risk of producing a dead lock if
the following scenario happens:

1) The main thread starts a GC and tries to stop all other threads.
2) The worker thread is waiting on a signal without entering the SafePointScope.
The main thread cannot stop the worker thread forever and thus cannot make
progress. Dead lock.

However, (to avoid this kind of dead lock) code has been added to timeout the GC
if the GCing thread fails at stopping other threads within 100 ms. So not
entering SafePointScope will just cause the timeout -- it won't cause a dead
lock.

This fixes a hard-to-reproduce timing bug that's been a big concern of one of
our partners.

BUG=592124,608603
TEST=manual

Review-Url: https://codereview.chromium.org/2009093002
Cr-Commit-Position: refs/heads/master@{#399265}
(cherry picked from commit f466a07e32ce1c8083dc726c7391e68b2ff2e7b0)
==========

to

==========
Fix for sync filesystem app crash.

Previously removing the SafePointScope had a risk of producing a dead lock if
the following scenario happens:

1) The main thread starts a GC and tries to stop all other threads.
2) The worker thread is waiting on a signal without entering the SafePointScope.
The main thread cannot stop the worker thread forever and thus cannot make
progress. Dead lock.

However, (to avoid this kind of dead lock) code has been added to timeout the GC
if the GCing thread fails at stopping other threads within 100 ms. So not
entering SafePointScope will just cause the timeout -- it won't cause a dead
lock.

This fixes a hard-to-reproduce timing bug that's been a big concern of one of
our partners.

BUG=592124,608603
TEST=manual

Review-Url: https://codereview.chromium.org/2009093002
Cr-Commit-Position: refs/heads/master@{#399265}
(cherry picked from commit f466a07e32ce1c8083dc726c7391e68b2ff2e7b0)

Committed:
https://chromium.googlesource.com/chromium/src/+/d023da3f77306882389a2d8a09a7...
==========

[achuithb, 2016-06-14 19:44:55]

Committed patchset #1 (id:1) manually as
d023da3f77306882389a2d8a09a7125815a00b31.