Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 2065823002: Use selfVisualOverflowRect instead of visualOverflowRect as bounds of painting of LayoutBox (Closed)

Created:
4 years, 6 months ago by Xianzhu
Modified:
4 years, 6 months ago
Reviewers:
pdr., chrishtr, trchen
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, slimming-paint-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use selfVisualOverflowRect instead of visualOverflowRect as bounds of painting of LayoutBox BUG=619366 R=chrishtr@chromium.org, pdr@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/d83e0941fdb33cc09fe03b63457fee585bbd6467

Patch Set 1 #

Patch Set 2 : - #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BoxPainter.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
Xianzhu
4 years, 6 months ago (2016-06-14 19:00:31 UTC) #2
chrishtr
lgtm
4 years, 6 months ago (2016-06-15 05:31:09 UTC) #4
pdr.
LGTM 2
4 years, 6 months ago (2016-06-15 09:52:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065823002/1
4 years, 6 months ago (2016-06-15 16:38:10 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/244721)
4 years, 6 months ago (2016-06-15 18:13:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065823002/1
4 years, 6 months ago (2016-06-15 18:21:24 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/d83e0941fdb33cc09fe03b63457fee585bbd6467 Cr-Commit-Position: refs/heads/master@{#399962}
4 years, 6 months ago (2016-06-15 18:26:51 UTC) #13
Xianzhu
4 years, 6 months ago (2016-06-15 18:27:58 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
d83e0941fdb33cc09fe03b63457fee585bbd6467.

Powered by Google App Engine
This is Rietveld 408576698