Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2065813002: DevTools: allow inspector protocol generator reuse as a gyp target. (Closed)

Created:
4 years, 6 months ago by pfeldman
Modified:
4 years, 6 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: allow inspector protocol generator reuse as a gyp target. TBR=dgozman Committed: https://crrev.com/335e5ea4158bdd1ed86601cf82a29a0699315a6c Cr-Commit-Position: refs/heads/master@{#399590}

Patch Set 1 #

Patch Set 2 : clean #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/v8_inspector.gyp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065813002/20001
4 years, 6 months ago (2016-06-13 21:35:12 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-13 22:56:11 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-13 22:58:11 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/335e5ea4158bdd1ed86601cf82a29a0699315a6c
Cr-Commit-Position: refs/heads/master@{#399590}

Powered by Google App Engine
This is Rietveld 408576698