Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 2065733004: fix dartdevc command to work with --dart-sdk flag that is being passed (Closed)

Created:
4 years, 6 months ago by Jennifer Messerly
Modified:
4 years, 6 months ago
Reviewers:
vsm
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fix dartdevc command to work with --dart-sdk flag that is being passed R=vsm@google.com Committed: https://github.com/dart-lang/sdk/commit/95117b6086362de49c3d4e802985830e69cba7f7

Patch Set 1 #

Patch Set 2 : roll_again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Jennifer Messerly
This rolls in https://github.com/dart-lang/dev_compiler/pull/590 into the SDK.
4 years, 6 months ago (2016-06-14 22:09:16 UTC) #2
vsm
lgtm This looks like the branch - are you bumping back to master on another ...
4 years, 6 months ago (2016-06-14 22:12:34 UTC) #3
Jennifer Messerly
4 years, 6 months ago (2016-06-14 22:19:01 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
95117b6086362de49c3d4e802985830e69cba7f7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698