chrome/test/chromedriver/server/http_handler.cc - Issue 2065733002: Add a method to override the network conditions of the ChromeDriver session.

Unified Diff: chrome/test/chromedriver/server/http_handler.cc

Issue 2065733002: Add a method to override the network conditions of the ChromeDriver session. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Test XHR with setting network emulation and refactored netowrk setter method Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/chromedriver/client/chromedriver.py ('K') | « chrome/test/chromedriver/client/command_executor.py ('k') | chrome/test/chromedriver/session_commands.h » ('j') | chrome/test/chromedriver/session_commands.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/chromedriver/server/http_handler.cc

diff --git a/chrome/test/chromedriver/server/http_handler.cc b/chrome/test/chromedriver/server/http_handler.cc

index 189bdb53ca6832b1feef717525b01be9c06c8488..b413e51f41098ae04550d3b4b8ade0a10308f9c6 100644

--- a/chrome/test/chromedriver/server/http_handler.cc

+++ b/chrome/test/chromedriver/server/http_handler.cc

@@ -382,6 +382,11 @@ HttpHandler::HttpHandler(

"session/:sessionId/location",

WrapToCommand("SetGeolocation", base::Bind(&ExecuteSetLocation))),

CommandMapping(

+ kPost,

+ "session/:sessionId/network_connection",

+ WrapToCommand("SetNetworkConnection",

+ base::Bind(&ExecuteSetNetworkConnection))),

prasadv 2016/06/17 18:43:35 Nit: Please correct indentation, also use only spa

samuong 2016/06/17 22:01:30 You can run "git cl presubmit" which will automati

roisinmcl 2016/06/20 18:14:16 Done.

+ CommandMapping(

kGet,

"session/:sessionId/chromium/network_conditions",

WrapToCommand("GetNetworkConditions",