Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1144)

Unified Diff: chrome/test/chromedriver/chrome/chrome_desktop_impl.h

Issue 2065733002: Add a method to override the network conditions of the ChromeDriver session. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed style issues. Changed names for consistency. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/chrome/chrome_desktop_impl.h
diff --git a/chrome/test/chromedriver/chrome/chrome_desktop_impl.h b/chrome/test/chromedriver/chrome/chrome_desktop_impl.h
index 9b121186480604de597edd4079b96d62e6ffb8b3..9f9b98f083b07455bcf586d6a9947bd4dbe94bbf 100644
--- a/chrome/test/chromedriver/chrome/chrome_desktop_impl.h
+++ b/chrome/test/chromedriver/chrome/chrome_desktop_impl.h
@@ -57,11 +57,15 @@ class ChromeDesktopImpl : public ChromeImpl {
const base::CommandLine& command() const;
+ int GetNetworkConnection() const;
+ void SetNetworkConnection(const int& network_connection);
samuong 2016/06/29 18:37:54 "const int&" seems needlessly complex, is there an
roisinmcl 2016/06/29 19:45:00 Done.
+
private:
base::Process process_;
base::CommandLine command_;
base::ScopedTempDir user_data_dir_;
base::ScopedTempDir extension_dir_;
+ int network_connection_;
// Lazily initialized, may be null.
std::unique_ptr<AutomationExtension> automation_extension_;
« no previous file with comments | « no previous file | chrome/test/chromedriver/chrome/chrome_desktop_impl.cc » ('j') | chrome/test/chromedriver/test/run_py_tests.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698