Issue 206573002: Fix for VS2010 compiler warning.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 206573002: Fix for VS2010 compiler warning. (Closed)

Created:
6 years, 9 months ago by Daniel Bratell

Modified:
6 years, 9 months ago

Reviewers:
cpu_(ooo_6.6-7.5), zturner

CC:
chromium-reviews, eirik

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix for VS2010 compiler warning. Including the enum type name between scope and enum is a new invention and older compilers warn about it being a non standard extension. It's not needed so let us just drop it. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258531

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	win8/delegate_execute/command_execute_impl.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Daniel Bratell

cpu, just a VS2010 compiler warning in code zturner added recently. Trivial change.

6 years, 9 months ago (2014-03-20 15:37:27 UTC) #1

zturner

On 2014/03/20 15:37:27, Daniel Bratell wrote: > cpu, just a VS2010 compiler warning in code ...

6 years, 9 months ago (2014-03-20 16:10:39 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bratell@opera.com/206573002/1

6 years, 9 months ago (2014-03-20 22:50:17 UTC) #5

Message was sent while issue was closed.

Change committed as 258531

Expand Messages | Collapse Messages