third_party/WebKit/LayoutTests/paint/text/text-match-highlights-big-line-height.html - Issue 2065723002: Don't use selection bounds to paint document marker

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/paint/text/text-match-highlights-big-line-height.html

Issue 2065723002: Don't use selection bounds to paint document marker (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Don't use selection bounds to paint document marker Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/TestExpectations ('k') | third_party/WebKit/LayoutTests/paint/text/text-match-highlights-big-line-height-expected.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/paint/text/text-match-highlights-big-line-height.html

diff --git a/third_party/WebKit/LayoutTests/paint/text/text-match-highlights-big-line-height.html b/third_party/WebKit/LayoutTests/paint/text/text-match-highlights-big-line-height.html

new file mode 100644

index 0000000000000000000000000000000000000000..45d6f255770fbd7a5cfbf0d282cfc8e90b8860f4

--- /dev/null

+++ b/third_party/WebKit/LayoutTests/paint/text/text-match-highlights-big-line-height.html

@@ -0,0 +1,26 @@

+<!DOCTYPE html>

+Text match highlight should not extend into the line spacing.

+<div style="line-height: 30px; font-size: 15px">

+<br id='b1'>AAA

+</div>

+<div style="line-height: 30px; font-size: 15px; writing-mode: vertical-rl">

+<br id='b2'>AAA

+</div>

+<script>

+function highlightRange(element, start, end, active) {

+ var range = document.createRange();

+ range.setStart(element, start);

+ range.setEnd(element, end);

+ internals.addTextMatchMarker(range, active);

+if (window.internals) {

+ onload = function() {

+ highlightRange(document.getElementById('b1').nextSibling, 0, 3, false);

+ highlightRange(document.getElementById('b2').nextSibling, 0, 3, true);

+ internals.setMarkedTextMatchesAreHighlighted(document, true);

+ };

+</script>