third_party/WebKit/LayoutTests/paint/text/text-match-highlights-big-line-height.html - Issue 2065723002: Don't use selection bounds to paint document marker

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/paint/text/text-match-highlights-big-line-height.html

Issue 2065723002: Don't use selection bounds to paint document marker (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Don't use selection bounds to paint document marker Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/paint/text/text-match-highlights-big-line-height-expected.html » ('j') | third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 Text match highlight should not extend into the line spacing.

	3 <div style="line-height: 30px; font-size: 15px">

	4 <br id='b1'>AAA

	5 </div>

	6

	7 <div style="line-height: 30px; font-size: 15px; writing-mode: vertical-rl">

	8 <br id='b2'>AAA

	9 </div>

	10

	11 <script>

	12 function highlightRange(element, start, end, active) {

	13 var range = document.createRange();

	14 range.setStart(element, start);

	15 range.setEnd(element, end);

	16 internals.addTextMatchMarker(range, active);

	17 }

	18

	19 if (window.internals) {

	20 onload = function() {
	jbroman 2016/06/15 08:37:10 Is the execution of the onload handler guaranteed Is the execution of the onload handler guaranteed to beat the taking of the screenshot? It might be safer to use testRunner.waitUntilDone/notifyDOne. Xianzhu 2016/06/15 16:40:48 Yes, layout test wait for finish of onload and tak Show quoted text On 2016/06/15 08:37:10, jbroman wrote: > Is the execution of the onload handler guaranteed to beat the taking of the > screenshot? It might be safer to use testRunner.waitUntilDone/notifyDOne. Yes, layout test wait for finish of onload and take snapshot. jbroman 2016/06/15 18:19:47 Ah yes, of course. I must have forgotten that it g Show quoted text On 2016/06/15 at 16:40:48, Xianzhu wrote: > On 2016/06/15 08:37:10, jbroman wrote: > > Is the execution of the onload handler guaranteed to beat the taking of the > > screenshot? It might be safer to use testRunner.waitUntilDone/notifyDOne. > > Yes, layout test wait for finish of onload and take snapshot. Ah yes, of course. I must have forgotten that it gets dispatched synchronously. My bad. :)
	21 highlightRange(document.getElementById('b1').nextSibling, 0, 3, false);

	22 highlightRange(document.getElementById('b2').nextSibling, 0, 3, true);

	23 internals.setMarkedTextMatchesAreHighlighted(document, true);

	24 };

	25 }

	26 </script>

OLD	NEW