Add profile selector menu to app list.

ui/app_list/app_list_menu.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/app_list/app_list_menu.h"
 
+#include "grit/ui_resources.h"
 #include "grit/ui_strings.h"
 #include "ui/app_list/app_list_view_delegate.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/models/menu_separator_types.h"
 #include "ui/base/resource/resource_bundle.h"
 
 namespace app_list {
 
-AppListMenu::AppListMenu(AppListViewDelegate* delegate)
+AppListMenu::AppListMenu(AppListViewDelegate* delegate,
+                         const AppListModel::Users& users)
     : menu_model_(this),
-      delegate_(delegate) {
+      delegate_(delegate),
+      users_(users) {
   InitMenu();
 }
 
 AppListMenu::~AppListMenu() {}
 
 void AppListMenu::InitMenu() {
-  menu_model_.AddItem(CURRENT_USER, base::string16());
-  menu_model_.AddSeparator(ui::NORMAL_SEPARATOR);
+  // User selector menu section.

[tapted, 2013/09/10 00:29:26]

nit: perhaps mention that when there is exactly 1 user, no selector items are
added so people don't think you're crazy checking >1 below instead of >0

[calamity, 2013/09/10 22:50:46]

Done.

+  if (users_.size() > 1) {
+    ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
+    for (size_t i = 0; i < users_.size(); ++i) {
+      menu_model_.AddItem(SELECT_PROFILE + i, users_[i]->name);
+      menu_model_.SetSublabel(i, users_[i]->email);

[tapted, 2013/09/10 00:29:26]

You should do

int menu_index = GetIndexOfCommandId(SELECT_PROFILE + i);
menu_model_.SetSublabel(menu_index, users_[i]->email);

etc.

or... maybe a DCHECK_EQ(i, GetIndexOfCommandId(SELECT_PROFILE + i)); But I think
I like the one above better.

Also did you try using GetSublabelAt(..) instead? Not sure it would be better,
just curious.

[calamity, 2013/09/10 22:50:46]

Done. What was GetSublabelAt() for?

+      if (users_[i]->active) {

[tapted, 2013/09/10 00:29:26]

Also, why not IsCommandIdChecked? Maybe a comment would be good here.

[calamity, 2013/09/10 22:50:46]

Done.

+        menu_model_.SetIcon(i, gfx::Image(*rb.GetImageSkiaNamed(
+            IDR_APP_LIST_CURRENT_USER_INDICATOR)));
+      }
+    }
+    menu_model_.AddSeparator(ui::NORMAL_SEPARATOR);
+  }
 
   menu_model_.AddItem(SHOW_SETTINGS, l10n_util::GetStringUTF16(
       IDS_APP_LIST_OPEN_SETTINGS));
 
   menu_model_.AddItem(SHOW_HELP, l10n_util::GetStringUTF16(
       IDS_APP_LIST_HELP));
 
   menu_model_.AddItem(SHOW_FEEDBACK, l10n_util::GetStringUTF16(
       IDS_APP_LIST_OPEN_FEEDBACK));
 }
 
 bool AppListMenu::IsCommandIdChecked(int command_id) const {
   return false;
 }
 
 bool AppListMenu::IsCommandIdEnabled(int command_id) const {
   return true;
 }
 
 bool AppListMenu::GetAcceleratorForCommandId(int command_id,
                                              ui::Accelerator* accelerator) {
   return false;
 }
 
 void AppListMenu::ExecuteCommand(int command_id, int event_flags) {
+  if (command_id >= SELECT_PROFILE) {
+    delegate_->ShowForProfileByPath(
+        users_[command_id - SELECT_PROFILE]->profile_path);
+    return;
+  }
   switch (command_id) {
     case CURRENT_USER:
       break;  // Do nothing.
     case SHOW_SETTINGS:
       delegate_->OpenSettings();
       break;
     case SHOW_HELP:
       delegate_->OpenHelp();
       break;
     case SHOW_FEEDBACK:
       delegate_->OpenFeedback();
       break;
     default:
       NOTREACHED();
   }
 }
 
 }  // namespace app_list