Add profile selector menu to app list.

ui/base/models/list_model.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_BASE_MODELS_LIST_MODEL_H_
 #define UI_BASE_MODELS_LIST_MODEL_H_
 
 #include "base/basictypes.h"
 #include "base/logging.h"
 #include "base/memory/scoped_vector.h"
@@ skipping 16 matching lines @@
     DCHECK_LE(index, item_count());
     items_.insert(items_.begin() + index, item);
     NotifyItemsAdded(index, 1);
   }
 
   // Convenience function to append an item to the model.
   void Add(ItemType* item) {
     AddAt(item_count(), item);
   }
 
+  // Add a vector of items to the end of the model. This triggers one
+  // notification after adding all items.
+  void AddAll(ScopedVector<ItemType> new_items) {
+    size_t count = item_count();

[tapted, 2013/08/05 03:01:39]

I think this needs either a DCHECK(!new_items.empty()), or an early return.

+    std::vector<ItemType*> new_items_released;
+    new_items.release(&new_items_released);
+    items_.insert(items_.end(),
+                  new_items_released.begin(),
+                  new_items_released.end());
+    NotifyItemsAdded(count, items_.size());

[tapted, 2013/08/05 03:01:39]

items_.size() isn't right -- it should be new_items_released.size(). Or
items_.size() - count. (Maybe DCHECK_EQ for those two anyway).

+  }
+
   // Removes an item at given |index| from the model. Note the removed item
   // is NOT deleted and it's up to the caller to delete it.
   ItemType* RemoveAt(size_t index) {
     DCHECK_LT(index, item_count());
     ItemType* item = items_[index];
     items_.weak_erase(items_.begin() + index);
     NotifyItemsRemoved(index, 1);
     return item;
   }
 
@@ skipping 76 matching lines @@
  private:
   ScopedVector<ItemType> items_;
   ObserverList<ListModelObserver> observers_;
 
   DISALLOW_COPY_AND_ASSIGN(ListModel<ItemType>);
 };
 
 }  // namespace ui
 
 #endif  // UI_BASE_MODELS_LIST_MODEL_H_