Add profile selector menu to app list.

ui/app_list/app_list_menu.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_APP_LIST_APP_LIST_MENU_H_
 #define UI_APP_LIST_APP_LIST_MENU_H_
 
+#include <vector>

[tapted, 2013/08/05 03:01:39]

I guess the header doesn't need this any more, since it's now a typedef?

[calamity, 2013/08/08 04:52:12]

Done.

+
+#include "ui/app_list/app_list_model.h"
 #include "ui/base/models/simple_menu_model.h"
 
+namespace ui {
+struct AvatarMenuItemModel;
+}
+
 namespace app_list {
 
 class AppListViewDelegate;
 
 // Menu for the app list. This is shown in the top right hand corner of the
 // app list.
 // TODO(benwells): We should consider moving this into Chrome.
 class AppListMenu : public ui::SimpleMenuModel::Delegate {
  public:
   enum AppListMenuCommands {
     CURRENT_USER,
     SHOW_SETTINGS,
     SHOW_HELP,
     SHOW_FEEDBACK,
+    // |SELECT_PROFILE| must remain the last enum because values greater than
+    // |SELECT_PROFILE| are used to indicate a profile index.
+    SELECT_PROFILE,
   };
 
-  explicit AppListMenu(AppListViewDelegate* delegate);
+  AppListMenu(
+      AppListViewDelegate* delegate,
+      const app_list::AppListModel::ProfileMenuItems& profile_menu_items);

[tapted, 2013/08/05 03:01:39]

nit: doesn't need app_list::

[calamity, 2013/08/08 04:52:12]

Done.

[calamity, 2013/08/08 04:52:12]

Done.

   virtual ~AppListMenu();
 
   ui::SimpleMenuModel* menu_model() { return &menu_model_; }
 
  private:
   void InitMenu();
 
   virtual bool IsCommandIdChecked(int command_id) const OVERRIDE;
   virtual bool IsCommandIdEnabled(int command_id) const OVERRIDE;
   virtual bool GetAcceleratorForCommandId(
       int command_id,
       ui::Accelerator* accelerator) OVERRIDE;
   virtual void ExecuteCommand(int command_id, int event_flags) OVERRIDE;
 
   ui::SimpleMenuModel menu_model_;
+  ui::SimpleMenuModel profiles_model_;
   AppListViewDelegate* delegate_;
+  const app_list::AppListModel::ProfileMenuItems& profile_menu_items_;

[tapted, 2013/08/05 03:01:39]

I don't usually see things declared this way in Chrome.. Maybe a weak pointer?
Either way, it should have a comment saying who owns it. The app_list:: is also
redundant.

[koz (OOO until 15th September), 2013/08/05 03:52:13]

Right - this should probably be a value.

[calamity, 2013/08/08 04:52:12]

Done.

 
   DISALLOW_COPY_AND_ASSIGN(AppListMenu);
 };
 
 }  // namespace app_list
 
 #endif  // UI_APP_LIST_APP_LIST_MENU_H_