Add profile selector menu to app list.

chrome/browser/ui/app_list/app_list_service_impl.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_APP_LIST_APP_LIST_SERVICE_IMPL_H_
 #define CHROME_BROWSER_UI_APP_LIST_APP_LIST_SERVICE_IMPL_H_
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/profiles/profile_info_cache_observer.h"
 #include "chrome/browser/profiles/profile_loader.h"
 #include "chrome/browser/ui/app_list/app_list_service.h"
-#include "content/public/browser/notification_observer.h"
-#include "content/public/browser/notification_registrar.h"
 
 namespace base {
 class FilePath;
 }
 
 namespace content {
 class NotificationSource;
 class NotificationDetails;
 }
 
 // Parts of the AppListService implementation shared between platforms.
 class AppListServiceImpl : public AppListService,
-                           public ProfileInfoCacheObserver,
-                           public content::NotificationObserver {
+                           public ProfileInfoCacheObserver{

[tapted, 2013/08/05 03:01:39]

space before {

[calamity, 2013/08/08 04:52:12]

Done.

  public:
   static void RecordAppListLaunch();
   static void RecordAppListAppLaunch();
   static void SendAppListStats();
 
+  // Shows the app list for the profile at the current |profile_path|. If the
+  // profile has not been loaded, this will load the profile and then show the
+  // app list.
+  virtual void Show() OVERRIDE;

[tapted, 2013/08/05 03:01:39]

nit: there should be a comment saying these are overloaded from AppListService.
It would be nice to keep all the functions grouped together - I'll see if I can
find the place in this patch which convinced you to make them public...

[calamity, 2013/08/08 04:52:12]

AppListControllerDelegateWin calls Show and SetProfilePath.

+  virtual void SetProfilePath(const base::FilePath& profile_path) OVERRIDE;
+
  protected:
   AppListServiceImpl();
   virtual ~AppListServiceImpl();
 
   Profile* profile() const { return profile_; }
   void SetProfile(Profile* new_profile);
   void InvalidatePendingProfileLoads();
   ProfileLoader& profile_loader() { return profile_loader_; }
   const ProfileLoader& profile_loader() const { return profile_loader_; }
 
   // Process command line flags shared between desktop implementations of the
   // app list. Currently this allows for enabling or disabling the app list.
   void HandleCommandLineFlags(Profile* initial_profile);
 
   // Create a platform-specific shortcut for the app list.
   virtual void CreateShortcut();
 
   // Called in response to observed successful and unsuccessful signin changes.
   virtual void OnSigninStatusChanged();
 
   // AppListService overrides:
   virtual void HandleFirstRun() OVERRIDE;
   virtual void Init(Profile* initial_profile) OVERRIDE;
 
   // Returns the app list path configured in BrowserProcess::local_state().
   virtual base::FilePath GetProfilePath(
       const base::FilePath& user_data_dir) OVERRIDE;
-  virtual void SetProfilePath(const base::FilePath& profile_path) OVERRIDE;
-  virtual void Show() OVERRIDE;
   virtual void EnableAppList(Profile* initial_profile) OVERRIDE;
   virtual AppListControllerDelegate* CreateControllerDelegate() OVERRIDE;
 
  private:
   // Loads a profile asynchronously and calls OnProfileLoaded() when done.
   void LoadProfileAsync(const base::FilePath& profile_file_path);
 
   // Callback for asynchronous profile load.
   void OnProfileLoaded(int profile_load_sequence_id,
                        Profile* profile,
                        Profile::CreateStatus status);
 
   virtual Profile* GetCurrentAppListProfile() OVERRIDE;
 
   // ProfileInfoCacheObserver overrides:
   virtual void OnProfileWillBeRemoved(
       const base::FilePath& profile_path) OVERRIDE;
 
-  // content::NotificationObserver
-  virtual void Observe(int type,
-                       const content::NotificationSource& source,
-                       const content::NotificationDetails& details) OVERRIDE;
-
   // The profile the AppList is currently displaying.
   Profile* profile_;
 
   // Incremented to indicate that pending profile loads are no longer valid.
   int profile_load_sequence_id_;
 
   // How many profile loads are pending.
   int pending_profile_loads_;
 
   base::WeakPtrFactory<AppListServiceImpl> weak_factory_;
-  content::NotificationRegistrar registrar_;
 
   ProfileLoader profile_loader_;
 
   DISALLOW_COPY_AND_ASSIGN(AppListServiceImpl);
 };
 
 #endif  // CHROME_BROWSER_UI_APP_LIST_APP_LIST_SERVICE_IMPL_H_