third_party/WebKit/Source/core/paint/SVGRootPainter.cpp - Issue 2065593002: Unprefix the CSS 'filter' property

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/SVGRootPainter.cpp

Issue 2065593002: Unprefix the CSS 'filter' property (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove disabler. Try different DCHECK expressions. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/paint/SVGRootPainter.cpp

diff --git a/third_party/WebKit/Source/core/paint/SVGRootPainter.cpp b/third_party/WebKit/Source/core/paint/SVGRootPainter.cpp

index f58f6f74c09c1e5470f4ad678cb90fadeee30afb..f23a85a88a1e0b6bee91882f71d7dbb186b08b60 100644

--- a/third_party/WebKit/Source/core/paint/SVGRootPainter.cpp

+++ b/third_party/WebKit/Source/core/paint/SVGRootPainter.cpp

@@ -39,10 +39,6 @@ void SVGRootPainter::paint(const PaintInfo& paintInfo, const LayoutPoint& paintO

if (svg->hasEmptyViewBox())

return;

- // Don't paint if we don't have kids, except if we have filters we should paint those.

- if (!m_layoutSVGRoot.firstChild() && !SVGLayoutSupport::hasFilterResource(m_layoutSVGRoot))

- return;

PaintInfo paintInfoBeforeFiltering(paintInfo);

Optional<ScopedPaintChunkProperties> propertyScope;