third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp - Issue 2065593002: Unprefix the CSS 'filter' property

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

Issue 2065593002: Unprefix the CSS 'filter' property (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove disabler. Try different DCHECK expressions. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/CSSPropertyEquality.cpp ('k') | third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

diff --git a/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp b/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

index c0377df923235f63f5ab729e2474e687f4d5e76d..f0fb3cf80a337606b58d189a656e63a7acaf3002 100644

--- a/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

+++ b/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

@@ -2643,7 +2643,7 @@ const CSSValue* ComputedStyleCSSValueMapping::get(CSSPropertyID propertyID, cons

return CSSPrimitiveValue::create(style.shapeImageThreshold(), CSSPrimitiveValue::UnitType::Number);

case CSSPropertyShapeOutside:

return valueForShape(style, style.shapeOutside());

- case CSSPropertyWebkitFilter:

+ case CSSPropertyFilter:

return valueForFilter(style, style.filter());

case CSSPropertyBackdropFilter:

return valueForFilter(style, style.backdropFilter());

@@ -2834,10 +2834,6 @@ const CSSValue* ComputedStyleCSSValueMapping::get(CSSPropertyID propertyID, cons

if (!svgStyle.maskerResource().isEmpty())

return CSSURIValue::create(serializeAsFragmentIdentifier(svgStyle.maskerResource()));

return CSSPrimitiveValue::createIdentifier(CSSValueNone);

- case CSSPropertyFilter:

- if (!svgStyle.filterResource().isEmpty())

- return CSSURIValue::create(serializeAsFragmentIdentifier(svgStyle.filterResource()));

- return CSSPrimitiveValue::createIdentifier(CSSValueNone);

case CSSPropertyFloodColor:

return currentColorOrValidColor(style, svgStyle.floodColor());

case CSSPropertyLightingColor: