third_party/WebKit/Source/core/animation/ElementAnimations.cpp - Issue 2065593002: Unprefix the CSS 'filter' property

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/ElementAnimations.cpp

Issue 2065593002: Unprefix the CSS 'filter' property (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove disabler. Try different DCHECK expressions. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/animation/ElementAnimations.cpp

diff --git a/third_party/WebKit/Source/core/animation/ElementAnimations.cpp b/third_party/WebKit/Source/core/animation/ElementAnimations.cpp

index 5726411f6a86483211f9abc94193ceefdca1f3d7..ac2e90d31f144c9bfffc1365fb6bf0051c55f304 100644

--- a/third_party/WebKit/Source/core/animation/ElementAnimations.cpp

+++ b/third_party/WebKit/Source/core/animation/ElementAnimations.cpp

@@ -57,7 +57,7 @@ void ElementAnimations::updateAnimationFlags(ComputedStyle& style)

|| effect.affects(PropertyHandle(CSSPropertyScale))

|| effect.affects(PropertyHandle(CSSPropertyTranslate)))

style.setHasCurrentTransformAnimation(true);

- if (effect.affects(PropertyHandle(CSSPropertyWebkitFilter)))

+ if (effect.affects(PropertyHandle(CSSPropertyFilter)))

style.setHasCurrentFilterAnimation(true);

if (effect.affects(PropertyHandle(CSSPropertyBackdropFilter)))

style.setHasCurrentBackdropFilterAnimation(true);

@@ -69,7 +69,7 @@ void ElementAnimations::updateAnimationFlags(ComputedStyle& style)

if (style.hasCurrentTransformAnimation())

style.setIsRunningTransformAnimationOnCompositor(m_animationStack.hasActiveAnimationsOnCompositor(CSSPropertyTransform));

if (style.hasCurrentFilterAnimation())

- style.setIsRunningFilterAnimationOnCompositor(m_animationStack.hasActiveAnimationsOnCompositor(CSSPropertyWebkitFilter));

+ style.setIsRunningFilterAnimationOnCompositor(m_animationStack.hasActiveAnimationsOnCompositor(CSSPropertyFilter));

if (style.hasCurrentBackdropFilterAnimation())

style.setIsRunningBackdropFilterAnimationOnCompositor(m_animationStack.hasActiveAnimationsOnCompositor(CSSPropertyBackdropFilter));

}