Unprefix the CSS 'filter' property

third_party/WebKit/Source/core/layout/svg/SVGLayoutTreeAsText.cpp

 /*
  * Copyright (C) 2004, 2005, 2007, 2009 Apple Inc. All rights reserved.
  *           (C) 2005 Rob Buis <buis@kde.org>
  *           (C) 2006 Alexander Kellett <lypanov@kde.org>
  * Copyright (C) Research In Motion Limited 2010. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
@@ skipping 28 matching lines @@
 #include "core/layout/svg/LayoutSVGResourceMarker.h"
 #include "core/layout/svg/LayoutSVGResourceMasker.h"
 #include "core/layout/svg/LayoutSVGResourcePattern.h"
 #include "core/layout/svg/LayoutSVGResourceRadialGradient.h"
 #include "core/layout/svg/LayoutSVGRoot.h"
 #include "core/layout/svg/LayoutSVGShape.h"
 #include "core/layout/svg/LayoutSVGText.h"
 #include "core/layout/svg/SVGLayoutSupport.h"
 #include "core/layout/svg/line/SVGInlineTextBox.h"
 #include "core/layout/svg/line/SVGRootInlineBox.h"
+#include "core/paint/PaintLayer.h"
 #include "core/svg/LinearGradientAttributes.h"
 #include "core/svg/PatternAttributes.h"
 #include "core/svg/RadialGradientAttributes.h"
 #include "core/svg/SVGCircleElement.h"
 #include "core/svg/SVGEllipseElement.h"
 #include "core/svg/SVGLineElement.h"
 #include "core/svg/SVGLinearGradientElement.h"
 #include "core/svg/SVGPathElement.h"
 #include "core/svg/SVGPatternElement.h"
 #include "core/svg/SVGPointList.h"
@@ skipping 517 matching lines @@
         return;
     writeStandardPrefix(ts, container, indent);
     writePositionAndStyle(ts, container);
     ts << "\n";
     writeResources(ts, container, indent);
     writeChildren(ts, container, indent);
 }
 
 void write(TextStream& ts, const LayoutSVGRoot& root, int indent)
 {
+    if (!root.hasFilterInducingProperty()) {
+        writeStandardPrefix(ts, root, indent);
+        ts << root << "\n";
+        writeChildren(ts, root, indent);
+        return;
+    }
+
+    // An svg root element with a filter + reflect style can cause
+    // a compositing state query assert while dumping the tree, so
+    // quash it for now. FIXME: why is this so, why the assert?

[pdr., 2016/06/15 09:50:32]

Nit: TODO(fs) instead of FIXME

I've been using FIXME too but I recently learned this was changed in the blink
style guide.

[fs, 2016/06/15 11:02:43]

I think I inherited this one from noel =). Fixed.

+
+    DisableCompositingQueryAsserts disabler;
     writeStandardPrefix(ts, root, indent);
     ts << root << "\n";
     writeChildren(ts, root, indent);
 }
 
 void writeSVGText(TextStream& ts, const LayoutSVGText& text, int indent)
 {
     writeStandardPrefix(ts, text, indent);
     writeLayoutSVGTextBox(ts, text);
     ts << "\n";
@@ skipping 56 matching lines @@
     if (!svgStyle.clipperResource().isEmpty()) {
         if (LayoutSVGResourceClipper* clipper = getLayoutSVGResourceById<LayoutSVGResourceClipper>(object.document(), svgStyle.clipperResource())) {
             writeIndent(ts, indent);
             ts << " ";
             writeNameAndQuotedValue(ts, "clipPath", svgStyle.clipperResource());
             ts << " ";
             writeStandardPrefix(ts, *clipper, 0);
             ts << " " << clipper->resourceBoundingBox(&layoutObject) << "\n";
         }
     }
-    if (!svgStyle.filterResource().isEmpty()) {
-        if (LayoutSVGResourceFilter* filter = getLayoutSVGResourceById<LayoutSVGResourceFilter>(object.document(), svgStyle.filterResource())) {
-            writeIndent(ts, indent);
-            ts << " ";
-            writeNameAndQuotedValue(ts, "filter", svgStyle.filterResource());
-            ts << " ";
-            writeStandardPrefix(ts, *filter, 0);
-            ts << " " << filter->resourceBoundingBox(&layoutObject) << "\n";
+    if (style.hasFilter()) {
+        const FilterOperations& filterOperations = style.filter();
+        if (filterOperations.size() == 1) {
+            const FilterOperation& filterOperation = *filterOperations.at(0);
+            if (filterOperation.type() == FilterOperation::REFERENCE) {
+                const auto& referenceFilterOperation = toReferenceFilterOperation(filterOperation);
+                AtomicString id = SVGURIReference::fragmentIdentifierFromIRIString(referenceFilterOperation.url(), object.document());
+                if (LayoutSVGResourceFilter* filter = getLayoutSVGResourceById<LayoutSVGResourceFilter>(object.document(), id)) {
+                    writeIndent(ts, indent);
+                    ts << " ";
+                    writeNameAndQuotedValue(ts, "filter", id);
+                    ts << " ";
+                    writeStandardPrefix(ts, *filter, 0);
+                    ts << " " << filter->resourceBoundingBox(&layoutObject) << "\n";
+                }
+            }
         }
     }
 }
 
 } // namespace blink