Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(652)

Unified Diff: net/quic/quic_connection.cc

Issue 2065553002: Deprecate rolled back flag quic_only_one_sending_alarm. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@124348798
Patch Set: Rebase. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_connection.cc
diff --git a/net/quic/quic_connection.cc b/net/quic/quic_connection.cc
index 17d2442408a986f7fbaaf076742224f9ae991570..81c15036d55b4aa74449f706357c4c1dc73afe72 100644
--- a/net/quic/quic_connection.cc
+++ b/net/quic/quic_connection.cc
@@ -1387,11 +1387,7 @@ void QuicConnection::OnCanWrite() {
// We're not write blocked, but some stream didn't write out all of its
// bytes. Register for 'immediate' resumption so we'll keep writing after
// other connections and events have had a chance to use the thread.
- if (FLAGS_quic_only_one_sending_alarm) {
- send_alarm_->Update(clock_->ApproximateNow(), QuicTime::Delta::Zero());
- } else {
- resume_writes_alarm_->Set(clock_->ApproximateNow());
- }
+ resume_writes_alarm_->Set(clock_->ApproximateNow());
}
}
@@ -1888,10 +1884,6 @@ void QuicConnection::OnRetransmissionTimeout() {
return;
}
- // Cancel the send alarm to ensure TimeUntilSend is re-evaluated.
- if (FLAGS_quic_only_one_sending_alarm) {
- send_alarm_->Cancel();
- }
sent_packet_manager_->OnRetransmissionTimeout();
WriteIfNotBlocked();
@@ -2217,19 +2209,6 @@ void QuicConnection::SetRetransmissionAlarm() {
pending_retransmission_alarm_ = true;
return;
}
- // Once the handshake has been confirmed, the retransmission alarm should
- // never fire before the send alarm.
- if (FLAGS_quic_only_one_sending_alarm &&
- sent_packet_manager_->IsHandshakeConfirmed() && send_alarm_->IsSet()) {
- DCHECK(!sent_packet_manager_->GetRetransmissionTime().IsInitialized() ||
- sent_packet_manager_->GetRetransmissionTime() >=
- send_alarm_->deadline())
- << " retransmission_time:"
- << sent_packet_manager_->GetRetransmissionTime().ToDebuggingValue()
- << " send_alarm:" << send_alarm_->deadline().ToDebuggingValue();
- retransmission_alarm_->Cancel();
- return;
- }
QuicTime retransmission_time = sent_packet_manager_->GetRetransmissionTime();
retransmission_alarm_->Update(retransmission_time,
QuicTime::Delta::FromMilliseconds(1));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698