Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2065543002: [compiler] Move generator optimization heuristics. (Closed)

Created:
4 years, 6 months ago by Michael Starzinger
Modified:
4 years, 6 months ago
Reviewers:
neis
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Move generator optimization heuristics. This moves the decision whether to optimize generator or async functions into the AstNumberingVisitor. Optimization heuristics that are based on the function source should be encapsulated in this class. R=neis@chromium.org Committed: https://crrev.com/471f6baf9540656bd078ca7f6cb4cf671a528943 Cr-Commit-Position: refs/heads/master@{#36924}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M src/ast/ast-numbering.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/factory.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Michael Starzinger
4 years, 6 months ago (2016-06-13 10:55:12 UTC) #1
neis
lgtm
4 years, 6 months ago (2016-06-13 11:07:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065543002/1
4 years, 6 months ago (2016-06-13 11:08:38 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-13 11:42:25 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-13 11:42:27 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-13 11:43:38 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/471f6baf9540656bd078ca7f6cb4cf671a528943
Cr-Commit-Position: refs/heads/master@{#36924}

Powered by Google App Engine
This is Rietveld 408576698