Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(701)

Issue 2065523002: binding: Fixes the fallback mechanism of Document's named properties. (Closed)

Created:
4 years, 6 months ago by Yuki
Modified:
4 years, 6 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

binding: Fixes the fallback mechanism of Document's named properties. The old implementation only works for a) there is a hidden prototype, and documentWrapper->GetPrototype() actually returns itself, or b) fallbacked attributes are data-type properties. Since we made attributes be accessor-type properties _and_ removed the hidden prototype, the old implementation no longer works. Fixed the issue using V8's GetRealNamedPropertyInPrototypeChain(). BUG=619036 Committed: https://crrev.com/cccf8630bac25057f6afd30febf8c428cd486b8c Cr-Commit-Position: refs/heads/master@{#399461}

Patch Set 1 #

Patch Set 2 : Synced. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -6 lines) Patch
A third_party/WebKit/LayoutTests/fast/dom/HTMLDocument/named-item-not-found.html View 1 chunk +22 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp View 1 chunk +3 lines, -6 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
Yuki
Could you review this CL?
4 years, 6 months ago (2016-06-13 09:14:36 UTC) #2
haraken
LGTM
4 years, 6 months ago (2016-06-13 09:25:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065523002/1
4 years, 6 months ago (2016-06-13 09:37:54 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/237819)
4 years, 6 months ago (2016-06-13 11:12:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065523002/1
4 years, 6 months ago (2016-06-13 12:28:54 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/237918)
4 years, 6 months ago (2016-06-13 14:28:18 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065523002/20001
4 years, 6 months ago (2016-06-13 14:43:02 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-13 15:52:47 UTC) #15
commit-bot: I haz the power
4 years, 6 months ago (2016-06-13 15:54:09 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cccf8630bac25057f6afd30febf8c428cd486b8c
Cr-Commit-Position: refs/heads/master@{#399461}

Powered by Google App Engine
This is Rietveld 408576698