content/renderer/pepper/pepper_platform_audio_output.h - Issue 2065513004: Expose flash playback status and volume control to content renderer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/pepper/pepper_platform_audio_output.h

Issue 2065513004: Expose flash playback status and volume control to content renderer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@audio_focus_manager

Patch Set: addressing nits Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/pepper/pepper_audio_controller.cc ('K') | « content/renderer/pepper/pepper_audio_controller.cc ('k') | content/renderer/pepper/pepper_platform_audio_output.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/pepper/pepper_platform_audio_output.h

diff --git a/content/renderer/pepper/pepper_platform_audio_output.h b/content/renderer/pepper/pepper_platform_audio_output.h

index ea8771d6f90adc7c814d24c7dd73e241b4ad4e8e..439dc2b7dc2efedc119e71eb8688f38e6e9fe316 100644

--- a/content/renderer/pepper/pepper_platform_audio_output.h

+++ b/content/renderer/pepper/pepper_platform_audio_output.h

@@ -43,6 +43,10 @@ class PepperPlatformAudioOutput

// is created or after the stream is closed.

bool StopPlayback();

+ // Sets the volume. Returns false on error or if called before the stream

+ // is created or after the stream is closed.

+ bool SetVolume(double volume);

// Closes the stream. Make sure to call this before the object is

// destructed.

void ShutDown();

@@ -74,6 +78,7 @@ class PepperPlatformAudioOutput

void InitializeOnIOThread(const media::AudioParameters& params);

void StartPlaybackOnIOThread();

void StopPlaybackOnIOThread();

+ void SetVolumeOnIOThread(double volume);

void ShutDownOnIOThread();

// The client to notify when the stream is created. THIS MUST ONLY BE