chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java - Issue 2065493007: [Android] Use NTPRecyclerView for peeking card viewport height

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java

Issue 2065493007: [Android] Use NTPRecyclerView for peeking card viewport height (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Inline if-return statements Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardsLayoutOperations.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java

index bbddaf579827fb5fecbbe64ca3c7b302a54f347c..faa44c8979d9063d6f49fe64eca64bb86e526c1e 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java

@@ -92,8 +92,8 @@ public class CardViewHolder extends NewTabPageViewHolder {

/**

* Change the width, padding and child opacity of the card to give a smooth transition as the

* user scrolls.

- * @param viewportHeight The height of the containing view, to calculate when the transition

- * should start.

+ * @param viewportHeight The height of the containing viewport, i.e. the area inside the

+ * containing view that is available for drawing.

public void updatePeek(int viewportHeight) {

// The peeking card's resting position is |mMaxPeekPadding| from the bottom of the screen