Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: net/quic/quic_connection.cc

Issue 2065463002: Always send queued retransmission packets, because of write blocked socket, once the socket gets un… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/quic/quic_connection_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_connection.cc
diff --git a/net/quic/quic_connection.cc b/net/quic/quic_connection.cc
index 8e364e1fdfd5f2b803d3fd3dfe18162aa47a9aca..17d2442408a986f7fbaaf076742224f9ae991570 100644
--- a/net/quic/quic_connection.cc
+++ b/net/quic/quic_connection.cc
@@ -1737,6 +1737,13 @@ bool QuicConnection::ShouldDiscardPacket(const SerializedPacket& packet) {
return true;
}
+ // TODO(fayang): Remove IsUnacked and HasRetransmittableFrames from
+ // QuicSentPacketManagerInterface when deprecating
+ // gfe2_reloadable_flag_quic_always_write_queued_retransmissions.
+ if (FLAGS_quic_always_write_queued_retransmissions) {
+ return false;
+ }
+
// If a retransmission has been acked before sending, don't send it.
// This occurs if a packet gets serialized, queued, then discarded.
if (packet.transmission_type != NOT_RETRANSMISSION &&
« no previous file with comments | « no previous file | net/quic/quic_connection_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698