Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Unified Diff: mojo/edk/system/node_channel.h

Issue 2065453004: Always leak the Mojo parent pipe handle on child process shutdown. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comment Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/edk/system/channel_win.cc ('k') | mojo/edk/system/node_channel.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/edk/system/node_channel.h
diff --git a/mojo/edk/system/node_channel.h b/mojo/edk/system/node_channel.h
index 08f95633e29ada9b5ea47b14e4e509da81540cb7..e06a2334872e6ed39d5b41e2d4d6aec879410f25 100644
--- a/mojo/edk/system/node_channel.h
+++ b/mojo/edk/system/node_channel.h
@@ -101,6 +101,9 @@ class NodeChannel : public base::RefCountedThreadSafe<NodeChannel>,
// Permanently stop the channel from sending or receiving messages.
void ShutDown();
+ // Leaks the pipe handle instead of closing it on shutdown.
+ void LeakHandleOnShutdown();
+
// Invokes the bad message callback for this channel, if any.
void NotifyBadMessage(const std::string& error);
« no previous file with comments | « mojo/edk/system/channel_win.cc ('k') | mojo/edk/system/node_channel.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698