Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1233)

Unified Diff: mojo/edk/system/channel.h

Issue 2065453004: Always leak the Mojo parent pipe handle on child process shutdown. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comment Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/edk/system/channel.h
diff --git a/mojo/edk/system/channel.h b/mojo/edk/system/channel.h
index f65f41e7b932f11748f0a590e84dacd1cba45e4c..c3fb77bc906185a1547bed64b5249a90700d8bde 100644
--- a/mojo/edk/system/channel.h
+++ b/mojo/edk/system/channel.h
@@ -225,6 +225,10 @@ class Channel : public base::RefCountedThreadSafe<Channel> {
// Delegate::OnChannelError.
virtual void Write(MessagePtr message) = 0;
+ // Causes the platform handle to leak when this channel is shut down instead
+ // of closing it.
+ virtual void LeakHandle() = 0;
+
protected:
explicit Channel(Delegate* delegate);
virtual ~Channel();
« no previous file with comments | « chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc ('k') | mojo/edk/system/channel_posix.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698