Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Side by Side Diff: chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc

Issue 2065453004: Always leak the Mojo parent pipe handle on child process shutdown. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comment Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | mojo/edk/system/channel.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stdint.h> 5 #include <stdint.h>
6 6
7 #include "base/auto_reset.h" 7 #include "base/auto_reset.h"
8 #include "base/callback.h" 8 #include "base/callback.h"
9 #include "base/files/file_util.h" 9 #include "base/files/file_util.h"
10 #include "base/files/scoped_temp_dir.h" 10 #include "base/files/scoped_temp_dir.h"
(...skipping 430 matching lines...) Expand 10 before | Expand all | Expand 10 after
441 MakeSingleFakeGallery(&pref_id); 441 MakeSingleFakeGallery(&pref_id);
442 442
443 base::ListValue custom_args; 443 base::ListValue custom_args;
444 custom_args.AppendInteger(base::checked_cast<int>(pref_id)); 444 custom_args.AppendInteger(base::checked_cast<int>(pref_id));
445 custom_args.AppendString( 445 custom_args.AppendString(
446 browser()->profile()->GetPath().BaseName().MaybeAsASCII()); 446 browser()->profile()->GetPath().BaseName().MaybeAsASCII());
447 447
448 ASSERT_TRUE(RunMediaGalleriesTestWithArg("tourl", custom_args)) << message_; 448 ASSERT_TRUE(RunMediaGalleriesTestWithArg("tourl", custom_args)) << message_;
449 } 449 }
450 450
451 // The test failed continuosly on linux_ChromeOS. Disable it until the root 451 IN_PROC_BROWSER_TEST_F(MediaGalleriesPlatformAppBrowserTest, GetMetadata) {
452 // cause if fixed. crbug.com/618121.
453 IN_PROC_BROWSER_TEST_F(MediaGalleriesPlatformAppBrowserTest,
454 DISABLED_GetMetadata) {
455 RemoveAllGalleries(); 452 RemoveAllGalleries();
456 MakeSingleFakeGallery(NULL); 453 MakeSingleFakeGallery(NULL);
457 454
458 AddFileToSingleFakeGallery(media::GetTestDataFilePath("90rotation.mp4")); 455 AddFileToSingleFakeGallery(media::GetTestDataFilePath("90rotation.mp4"));
459 AddFileToSingleFakeGallery(media::GetTestDataFilePath("id3_png_test.mp3")); 456 AddFileToSingleFakeGallery(media::GetTestDataFilePath("id3_png_test.mp3"));
460 457
461 base::ListValue custom_args; 458 base::ListValue custom_args;
462 #if defined(USE_PROPRIETARY_CODECS) 459 #if defined(USE_PROPRIETARY_CODECS)
463 custom_args.AppendBoolean(true); 460 custom_args.AppendBoolean(true);
464 #else 461 #else
465 custom_args.AppendBoolean(false); 462 custom_args.AppendBoolean(false);
466 #endif 463 #endif
467 ASSERT_TRUE(RunMediaGalleriesTestWithArg("media_metadata", custom_args)) 464 ASSERT_TRUE(RunMediaGalleriesTestWithArg("media_metadata", custom_args))
468 << message_; 465 << message_;
469 } 466 }
OLDNEW
« no previous file with comments | « no previous file | mojo/edk/system/channel.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698