[module] Track script "module code" status

test/cctest/heap/test-heap.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 1613 matching lines @@
 
   {
     v8::HandleScope scope(CcTest::isolate());
     CompileRun(raw_source);
   }
 
   // The script should be in the cache now.
   MaybeHandle<SharedFunctionInfo> info = compilation_cache->LookupScript(
       source, Handle<Object>(), 0, 0,
       v8::ScriptOriginOptions(false, true, false), native_context,
-      language_mode);
+      language_mode, false);
   CHECK(!info.is_null());
 
   // Check that the code cache entry survives at least on GC.
   // (Unless --optimize-for-size, in which case it might get collected
   // immediately.)
   if (!FLAG_optimize_for_size) {
     heap->CollectAllGarbage();
     info = compilation_cache->LookupScript(
         source, Handle<Object>(), 0, 0,
         v8::ScriptOriginOptions(false, true, false), native_context,
-        language_mode);
+        language_mode, false);
     CHECK(!info.is_null());
   }
 
   // Progress code age until it's old and ready for GC.
   while (!info.ToHandleChecked()->code()->IsOld()) {
     // To guarantee progress, we have to MakeOlder with different parities.
     // We can't just use NO_MARKING_PARITY, since e.g. kExecutedOnceCodeAge is
     // always NO_MARKING_PARITY and the code age only progresses if the parity
     // is different.
     info.ToHandleChecked()->code()->MakeOlder(ODD_MARKING_PARITY);
     info.ToHandleChecked()->code()->MakeOlder(EVEN_MARKING_PARITY);
   }
 
   heap->CollectAllGarbage();
   // Ensure code aging cleared the entry from the cache.
   info = compilation_cache->LookupScript(
       source, Handle<Object>(), 0, 0,
       v8::ScriptOriginOptions(false, true, false), native_context,
-      language_mode);
+      language_mode, false);

[mike3, 2016/06/19 17:11:41]

Does this repetition justify a dedicated "not module" method signature? These
are just unit tests, but I'm not sure if they reflect a common use-case for
consumers.

[vogelheim, 2016/06/23 14:53:20]

IMHO, no. I'd suspect that most callers of LookupScript will need to know about
is_module anyhow.

If it's excessively burdensome in a test, I'd add a helper method in the test
file itself. I don't think that's the case here, though.

[mike3, 2016/06/25 19:31:45]

Acknowledged.

   CHECK(info.is_null());
 }
 
 
 static void OptimizeEmptyFunction(const char* name) {
   HandleScope scope(CcTest::i_isolate());
   EmbeddedVector<char, 256> source;
   SNPrintF(source,
            "function %s() { return 0; }"
            "%s(); %s();"
@@ skipping 5100 matching lines @@
   int mark_sweeps_performed = mark_sweep_count_after - mark_sweep_count_before;
   // The memory pressuer handler either performed two GCs or performed one and
   // started incremental marking.
   CHECK(mark_sweeps_performed == 2 ||
         (mark_sweeps_performed == 1 &&
          !heap->incremental_marking()->IsStopped()));
 }
 
 }  // namespace internal
 }  // namespace v8