[module] Track script "module code" status

src/parsing/parser.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/parsing/parser.h"
 
 #include "src/api.h"
 #include "src/ast/ast.h"
 #include "src/ast/ast-expression-rewriter.h"
 #include "src/ast/ast-expression-visitor.h"
@@ skipping 57 matching lines @@
 
   set_lazy();
   set_hash_seed(isolate_->heap()->HashSeed());
   set_stack_limit(isolate_->stack_guard()->real_climit());
   set_unicode_cache(isolate_->unicode_cache());
   set_language_mode(shared->language_mode());
   set_shared_info(shared);
 
   Handle<Script> script(Script::cast(shared->script()));
   set_script(script);
+
+  if (script->is_module()) {
+    set_module();
+  } else {
+    set_global();

[mike3, 2016/06/12 19:54:48]

Since ParseInfo keeps a reference to its Script, the dedicated `is_module` bit
in ParseInfo is now redundant. I was tempted to remove it and re-implement the
accessor function to simply reference the Script instance, but I ran across
this comment in `parsing/parser.h`:
...so I think that reducing duplication in this case would wind up making
titzer's job harder.

[vogelheim, 2016/06/14 15:20:50]

Removing the bit would also be ok; not sure if it's worth the effort, though.

[Ben (Titzer) isn't in this week, so I asked around. Removing those - at least
removing the script reference - isn't imminent; so that shouldn't keep us from
doing it.) Note that we'd still need the global flag, though.]

[vogelheim, 2016/06/14 15:20:50]

How do we know it's not an eval? (See more elaborate comment earlier in this
CL.)

[mike3, 2016/06/19 16:59:00]

Acknowledged.

+  }
+
   if (!script.is_null() && script->type() == Script::TYPE_NATIVE) {
     set_native();
   }
 }
 
 
 ParseInfo::ParseInfo(Zone* zone, Handle<Script> script) : ParseInfo(zone) {
   isolate_ = script->GetIsolate();
 
   set_hash_seed(isolate_->heap()->HashSeed());
   set_stack_limit(isolate_->stack_guard()->real_climit());
   set_unicode_cache(isolate_->unicode_cache());
   set_script(script);
 
+  if (script->is_module()) {
+    set_module();
+  } else {
+    set_global();

[vogelheim, 2016/06/14 15:20:49]

as above...

[mike3, 2016/06/19 16:59:00]

Acknowledged.

+  }
+
   if (script->type() == Script::TYPE_NATIVE) {
     set_native();
   }
 }
 
 
 FunctionEntry ParseData::GetFunctionEntry(int start) {
   // The current pre-data entry must be a FunctionEntry with the given
   // start position.
   if ((function_index_ + FunctionEntry::kSize <= Length()) &&
@@ skipping 6871 matching lines @@
                         try_block, target);
     final_loop = target;
   }
 
   return final_loop;
 }
 
 
 }  // namespace internal
 }  // namespace v8