[module] Track script "module code" status

src/compiler.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler.h"
 
 #include <algorithm>
 
 #include "src/ast/ast-numbering.h"
 #include "src/ast/prettyprinter.h"
@@ skipping 1504 matching lines @@
     }
     if (!script_name.is_null()) {
       script->set_name(*script_name);
       script->set_line_offset(line_offset);
       script->set_column_offset(column_offset);
     }
     script->set_origin_options(resource_options);
     if (!source_map_url.is_null()) {
       script->set_source_mapping_url(*source_map_url);
     }
+    script->set_is_module(is_module);
 
     // Compile the function and add it to the cache.
     Zone zone(isolate->allocator());
     ParseInfo parse_info(&zone, script);
     CompilationInfo info(&parse_info, Handle<JSFunction>::null());
-    if (is_module) {
-      parse_info.set_module();
-    } else {
-      parse_info.set_global();
-    }

[vogelheim, 2016/06/14 15:20:49]

You've moved this into the ParseInfo constructor. That's a good idea, but I
don't think this actually works. The thing is, a parse can be one either an
eval, or global, or a module [1]. *In* *this* *context* it cannot be an eval -
because we're compiling a script. But in the context of a ParseInfo constructor
it could be either of those three. Which is why here, we can set_global() if
it's not a module, but in the ParseInfo constructor that no longer makes sense.

[1] 
https://cs.chromium.org/chromium/src/v8/src/compiler.cc?type=cs&sq=package:ch...


I guess I'd set_global if !is_module; maybe just replace the set_module with a
DCHECK(parse_info.is_module()). That's not super pretty code, but at least it
lets the reader know what the expectation is in either case.

[mike3, 2016/06/19 16:58:59]

Acknowledged.

     if (compile_options != ScriptCompiler::kNoCompileOptions) {
       parse_info.set_cached_data(cached_data);
     }
     parse_info.set_compile_options(compile_options);
     parse_info.set_extension(extension);
     parse_info.set_context(context);
     if (FLAG_serialize_toplevel &&
         compile_options == ScriptCompiler::kProduceCodeCache) {
       info.PrepareForSerializing();
     }
@@ skipping 260 matching lines @@
     DCHECK(shared->is_compiled());
     function->set_literals(cached.literals);
   } else if (shared->is_compiled()) {
     // TODO(mvstanton): pass pretenure flag to EnsureLiterals.
     JSFunction::EnsureLiterals(function);
   }
 }
 
 }  // namespace internal
 }  // namespace v8