Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Issue 2065433002: Convert media-source*, no-autoplay* and remove-from* tests to testharness.js (Closed)

Created:
4 years, 6 months ago by Srirama
Modified:
4 years, 6 months ago
Reviewers:
fs, foolip
CC:
blink-reviews, chromium-reviews, eric.carlson_apple.com, feature-media-reviews_chromium.org, mlamouri+watch-blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert media-source*, no-autoplay* and remove-from* tests to testharness.js Cleaning up media-source*, no-autoplay* and remove-from* tests in media/ to use testharness.js instead of video-test.js. This will enable to upstream these tests to web-platform-tests. BUG=588956 Committed: https://crrev.com/0ec8e6ae9296f31ed138a57fc8c5a22e72b7b1e6 Cr-Commit-Position: refs/heads/master@{#399407}

Patch Set 1 #

Total comments: 8

Patch Set 2 : address comments #

Patch Set 3 : address comment #

Messages

Total messages: 19 (8 generated)
Srirama
PTAL
4 years, 6 months ago (2016-06-11 08:09:01 UTC) #3
fs
https://codereview.chromium.org/2065433002/diff/1/third_party/WebKit/LayoutTests/media/media-source-append-multiple.html File third_party/WebKit/LayoutTests/media/media-source-append-multiple.html (right): https://codereview.chromium.org/2065433002/diff/1/third_party/WebKit/LayoutTests/media/media-source-append-multiple.html#newcode16 third_party/WebKit/LayoutTests/media/media-source-append-multiple.html:16: audio.onloadedmetadata = null; This seems redundant with the definition ...
4 years, 6 months ago (2016-06-11 18:59:50 UTC) #4
Srirama
https://codereview.chromium.org/2065433002/diff/1/third_party/WebKit/LayoutTests/media/media-source-append-multiple.html File third_party/WebKit/LayoutTests/media/media-source-append-multiple.html (right): https://codereview.chromium.org/2065433002/diff/1/third_party/WebKit/LayoutTests/media/media-source-append-multiple.html#newcode16 third_party/WebKit/LayoutTests/media/media-source-append-multiple.html:16: audio.onloadedmetadata = null; On 2016/06/11 18:59:50, fs wrote: > ...
4 years, 6 months ago (2016-06-12 09:51:04 UTC) #5
fs
lgtm https://codereview.chromium.org/2065433002/diff/1/third_party/WebKit/LayoutTests/media/no-autoplay-with-user-gesture-requirement.html File third_party/WebKit/LayoutTests/media/no-autoplay-with-user-gesture-requirement.html (left): https://codereview.chromium.org/2065433002/diff/1/third_party/WebKit/LayoutTests/media/no-autoplay-with-user-gesture-requirement.html#oldcode41 third_party/WebKit/LayoutTests/media/no-autoplay-with-user-gesture-requirement.html:41: <video controls autoplay></video> On 2016/06/12 at 09:51:04, Srirama ...
4 years, 6 months ago (2016-06-12 13:55:39 UTC) #6
Srirama
https://codereview.chromium.org/2065433002/diff/1/third_party/WebKit/LayoutTests/media/no-autoplay-with-user-gesture-requirement.html File third_party/WebKit/LayoutTests/media/no-autoplay-with-user-gesture-requirement.html (left): https://codereview.chromium.org/2065433002/diff/1/third_party/WebKit/LayoutTests/media/no-autoplay-with-user-gesture-requirement.html#oldcode41 third_party/WebKit/LayoutTests/media/no-autoplay-with-user-gesture-requirement.html:41: <video controls autoplay></video> On 2016/06/12 13:55:39, fs wrote: > ...
4 years, 6 months ago (2016-06-12 15:29:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065433002/40001
4 years, 6 months ago (2016-06-12 15:29:52 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/237730)
4 years, 6 months ago (2016-06-12 17:35:50 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065433002/40001
4 years, 6 months ago (2016-06-13 03:00:02 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-13 04:14:14 UTC) #16
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-13 04:14:16 UTC) #17
commit-bot: I haz the power
4 years, 6 months ago (2016-06-13 04:16:27 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0ec8e6ae9296f31ed138a57fc8c5a22e72b7b1e6
Cr-Commit-Position: refs/heads/master@{#399407}

Powered by Google App Engine
This is Rietveld 408576698