Convert media-source*, no-autoplay* and remove-from* tests to testharness.js

Convert media-source*, no-autoplay* and remove-from* tests to testharness.js

Cleaning up media-source*, no-autoplay* and remove-from* tests
in media/ to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
Committed: https://crrev.com/0ec8e6ae9296f31ed138a57fc8c5a22e72b7b1e6
Cr-Commit-Position: refs/heads/master@{#399407}

[Srirama, 2016-06-11 08:06:39]

Description was changed from

==========
fix

BUG=
==========

to

==========
Convert media-source*, no-autoplay* and remove-from* tests to testharness.js

Cleaning up media-source*, no-autoplay* and remove-from* tests
in media/ to use testharness.js instead of video-test.js. 
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

[Srirama, 2016-06-11 08:09:01]

srirama.m@samsung.com changed reviewers:
+ foolip@chromium.org, fs@opera.com

[Srirama, 2016-06-11 08:09:01]

PTAL

[fs, 2016-06-11 18:59:50]

https://codereview.chromium.org/2065433002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/media/media-source-append-multiple.html
(right):

https://codereview.chromium.org/2065433002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/media-source-append-multiple.html:16:
audio.onloadedmetadata = null;
This seems redundant with the definition below? (This event wouldn't fire
synchronously, so redefining the handler ought to have no effect.)

https://codereview.chromium.org/2065433002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/media/no-autoplay-with-user-gesture-requirement.html
(left):

https://codereview.chromium.org/2065433002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/no-autoplay-with-user-gesture-requirement.html:41:
<video controls autoplay></video>
Previously this test used a <video> in the document, so that's probably
preferable to keep it like that.

https://codereview.chromium.org/2065433002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/media/no-autoplay-with-user-gesture-requirement.html
(right):

https://codereview.chromium.org/2065433002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/no-autoplay-with-user-gesture-requirement.html:17:
setTimeout(t.step_func_done(testPaused), 100);
Maybe fold testPaused into this as an anonymous function.

[Srirama, 2016-06-12 09:51:04]

https://codereview.chromium.org/2065433002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/media/media-source-append-multiple.html
(right):

https://codereview.chromium.org/2065433002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/media-source-append-multiple.html:16:
audio.onloadedmetadata = null;
On 2016/06/11 18:59:50, fs wrote:
> This seems redundant with the definition below? (This event wouldn't fire
> synchronously, so redefining the handler ought to have no effect.) 

Done.

https://codereview.chromium.org/2065433002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/media/no-autoplay-with-user-gesture-requirement.html
(left):

https://codereview.chromium.org/2065433002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/no-autoplay-with-user-gesture-requirement.html:41:
<video controls autoplay></video>
On 2016/06/11 18:59:50, fs wrote:
> Previously this test used a <video> in the document, so that's probably
> preferable to keep it like that. 

Done. Problem is we need to execute internals setting before the video is
created, otherwise it is not having an effect.

https://codereview.chromium.org/2065433002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/media/no-autoplay-with-user-gesture-requirement.html
(right):

https://codereview.chromium.org/2065433002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/no-autoplay-with-user-gesture-requirement.html:17:
setTimeout(t.step_func_done(testPaused), 100);
On 2016/06/11 18:59:50, fs wrote:
> Maybe fold testPaused into this as an anonymous function.

Done.

[fs, 2016-06-12 13:55:39]

lgtm

https://codereview.chromium.org/2065433002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/media/no-autoplay-with-user-gesture-requirement.html
(left):

https://codereview.chromium.org/2065433002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/no-autoplay-with-user-gesture-requirement.html:41:
<video controls autoplay></video>
On 2016/06/12 at 09:51:04, Srirama wrote:
> On 2016/06/11 18:59:50, fs wrote:
> > Previously this test used a <video> in the document, so that's probably
> > preferable to keep it like that. 
> 
> Done. Problem is we need to execute internals setting before the video is
created, otherwise it is not having an effect.

Acknowledged. I guess an alternate way would be to interleave <script> and
<video>:

<script>
internals....;
</script>
<video ...></video>
<script>
async_test(...);
</script>

?

[Srirama, 2016-06-12 15:29:32]

https://codereview.chromium.org/2065433002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/media/no-autoplay-with-user-gesture-requirement.html
(left):

https://codereview.chromium.org/2065433002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/no-autoplay-with-user-gesture-requirement.html:41:
<video controls autoplay></video>
On 2016/06/12 13:55:39, fs wrote:
> On 2016/06/12 at 09:51:04, Srirama wrote:
> > On 2016/06/11 18:59:50, fs wrote:
> > > Previously this test used a <video> in the document, so that's probably
> > > preferable to keep it like that. 
> > 
> > Done. Problem is we need to execute internals setting before the video is
> created, otherwise it is not having an effect.
> 
> Acknowledged. I guess an alternate way would be to interleave <script> and
> <video>:
> 
> <script>
> internals....;
> </script>
> <video ...></video>
> <script>
> async_test(...);
> </script>
> 
> ?

Done.

[Srirama, 2016-06-12 15:29:42]

The CQ bit was checked by srirama.m@samsung.com

[Srirama, 2016-06-12 15:29:43]

The patchset sent to the CQ was uploaded after l-g-t-m from fs@opera.com
Link to the patchset: https://codereview.chromium.org/2065433002/#ps40001
(title: "address comment")

[commit-bot: I haz the power, 2016-06-12 15:29:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2065433002/40001

[commit-bot: I haz the power, 2016-06-12 17:35:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-12 17:35:50]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Srirama, 2016-06-13 02:59:53]

The CQ bit was checked by srirama.m@samsung.com

[commit-bot: I haz the power, 2016-06-13 03:00:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2065433002/40001

[commit-bot: I haz the power, 2016-06-13 04:14:13]

Description was changed from

==========
Convert media-source*, no-autoplay* and remove-from* tests to testharness.js

Cleaning up media-source*, no-autoplay* and remove-from* tests
in media/ to use testharness.js instead of video-test.js. 
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

to

==========
Convert media-source*, no-autoplay* and remove-from* tests to testharness.js

Cleaning up media-source*, no-autoplay* and remove-from* tests
in media/ to use testharness.js instead of video-test.js. 
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

[commit-bot: I haz the power, 2016-06-13 04:14:14]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-13 04:14:16]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-13 04:16:26]

Description was changed from

==========
Convert media-source*, no-autoplay* and remove-from* tests to testharness.js

Cleaning up media-source*, no-autoplay* and remove-from* tests
in media/ to use testharness.js instead of video-test.js. 
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

to

==========
Convert media-source*, no-autoplay* and remove-from* tests to testharness.js

Cleaning up media-source*, no-autoplay* and remove-from* tests
in media/ to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956

Committed: https://crrev.com/0ec8e6ae9296f31ed138a57fc8c5a22e72b7b1e6
Cr-Commit-Position: refs/heads/master@{#399407}
==========

[commit-bot: I haz the power, 2016-06-13 04:16:27]

Patchset 3 (id:??) landed as
https://crrev.com/0ec8e6ae9296f31ed138a57fc8c5a22e72b7b1e6
Cr-Commit-Position: refs/heads/master@{#399407}