Re-land: Blink image-decoders: (lazy) deferred image decoding support for ICO

Re-land: Blink image-decoders: (lazy) deferred image decoding support for ICO

BUG=513306
original patch review-url: https://codereview.chromium.org/2044093002

Committed: https://crrev.com/f32e119c6c7ec9e98298fcd43a285b735f021952
Cr-Commit-Position: refs/heads/master@{#400383}

[aleksandar.stojiljkovic, 2016-06-16 12:06:30]

aleksandar.stojiljkovic@intel.com changed reviewers:
+ fmalita@chromium.org, pkasting@chromium.org, scroggo@chromium.org

[aleksandar.stojiljkovic, 2016-06-16 12:06:31]

Reland attempt. 

Patch set 2 addresses the issue causing the revert.
Copied the approach from WebP and GIF decoders'
decodeFrameCount. In case of failure, decodeFrameCount returns existing number
of frames.

The reason for reverting is (Dr Memory bot):

First breaking build:
https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%2...

ICOImageDecoderTests.parseAndDecodeByteByByte:
c:\b\build\slave\drm-cr\build\src\third_party\webkit\source\platform\image-decoders\imagedecodertesthelpers.cpp(83):
error: Expected: (frameCount) <= (decoder->frameCount()), actual: 2 vs 0
c:\b\build\slave\drm-cr\build\src\third_party\webkit\source\platform\image-decoders\imagedecodertesthelpers.cpp(83):
error: Expected: (frameCount) <= (decoder->frameCount()), actual: 3 vs 0
c:\b\build\slave\drm-cr\build\src\third_party\webkit\source\platform\image-decoders\imagedecodertesthelpers.cpp(83):
error: Expected: (frameCount) <= (decoder->frameCount()), actual: 1 vs 0
c:\b\build\slave\drm-cr\build\src\third_party\webkit\source\platform\image-decoders\imagedecodertesthelpers.cpp(83):
error: Expected: (frameCount) <= (decoder->frameCount()), actual: 1 vs 0.

[Peter Kasting, 2016-06-16 13:03:40]

LGTM

[f(malita), 2016-06-16 20:22:21]

lgtm

[aleksandar.stojiljkovic, 2016-06-17 04:36:16]

The CQ bit was checked by aleksandar.stojiljkovic@intel.com

[commit-bot: I haz the power, 2016-06-17 04:36:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2065423003/20001

[commit-bot: I haz the power, 2016-06-17 06:42:52]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-17 06:44:02]

Description was changed from

==========
Re-land: Blink image-decoders: (lazy) deferred image decoding support for ICO

BUG=513306

original patch review-url: https://codereview.chromium.org/2044093002
==========

to

==========
Re-land: Blink image-decoders: (lazy) deferred image decoding support for ICO

BUG=513306

original patch review-url: https://codereview.chromium.org/2044093002

Committed: https://crrev.com/f32e119c6c7ec9e98298fcd43a285b735f021952
Cr-Commit-Position: refs/heads/master@{#400383}
==========

[commit-bot: I haz the power, 2016-06-17 06:44:04]

Patchset 2 (id:??) landed as
https://crrev.com/f32e119c6c7ec9e98298fcd43a285b735f021952
Cr-Commit-Position: refs/heads/master@{#400383}

[benwells, 2016-06-20 10:28:24]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2080673002/ by benwells@chromium.org.

The reason for reverting is: This again caused errors on the DrMemorybots.

First failing build with this change:
https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%2...

Sample error:
ICOImageDecoderTests.parseAndDecodeByteByByte:
c:\b\build\slave\drm-cr\build\src\third_party\webkit\source\platform\image-decoders\imagedecodertesthelpers.cpp(83):
error: Expected: (frameCount) <= (decoder->frameCount()), actual: 2 vs 0
c:\b\build\slave\drm-cr\build\src\third_party\webkit\source\platform\image-decoders\imagedecodertesthelpers.cpp(83):
error: Expected: (frameCount) <= (decoder->frameCount()), actual: 3 vs 0
c:\b\build\slave\drm-cr\build\src\third_party\webkit\source\platform\image-decoders\imagedecodertesthelpers.cpp(83):
error: Expected: (frameCount) <= (decoder->frameCount()), actual: 1 vs 0
c:\b\build\slave\drm-cr\build\src\third_party\webkit\source\platform\image-decoders\imagedecodertesthelpers.cpp(83):
error: Expected: (frameCount) <= (decoder->frameCount()), actual: 1 vs 0.