Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: pkg/compiler/lib/src/compiler.dart

Issue 2065413002: Serialize and process patch metadata (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/compiler/lib/src/enqueue.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/compiler.dart
diff --git a/pkg/compiler/lib/src/compiler.dart b/pkg/compiler/lib/src/compiler.dart
index 94b573a422ddc5cc9fcc449ebd2af964a4cd4c8f..ced831b979ee5db2b06257f609a25ff0828a1fd5 100644
--- a/pkg/compiler/lib/src/compiler.dart
+++ b/pkg/compiler/lib/src/compiler.dart
@@ -1064,7 +1064,6 @@ abstract class Compiler implements LibraryLoaderListener {
return const WorldImpact();
}
WorldImpact worldImpact = analyzeElement(element);
- backend.onElementResolved(element);
world.registerProcessedElement(element);
return worldImpact;
});
@@ -1658,8 +1657,12 @@ class CompilerDiagnosticReporter extends DiagnosticReporter {
if (astElement.hasNode) {
Token from = astElement.node.getBeginToken();
Token to = astElement.node.getEndToken();
- if (astElement.metadata.isNotEmpty &&
- astElement.metadata.first.hasNode) {
+ if (astElement.metadata.isNotEmpty) {
+ if (!astElement.metadata.first.hasNode) {
+ // We might try to report an error while parsing the metadata
+ // itself.
+ return true;
+ }
from = astElement.metadata.first.node.getBeginToken();
}
return validateToken(from, to);
« no previous file with comments | « no previous file | pkg/compiler/lib/src/enqueue.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698