Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2065343003: Remove 10 minute cooldown period when remote rebooting a kiosk device. (Closed)

Created:
4 years, 6 months ago by Marton Hunyady
Modified:
4 years, 5 months ago
CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove 10 minute cooldown period when remote rebooting a kiosk device. BUG=619737 Committed: https://crrev.com/e36bafb7228006c262f219d0926345a39364de30 Cr-Commit-Position: refs/heads/master@{#402760}

Patch Set 1 #

Patch Set 2 : Remove unused include #

Total comments: 2

Patch Set 3 : Remove TerminateImpl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -38 lines) Patch
M chrome/browser/chromeos/policy/remote_commands/device_command_reboot_job.h View 1 2 2 chunks +0 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/policy/remote_commands/device_command_reboot_job.cc View 3 chunks +5 lines, -29 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Marton Hunyady
4 years, 6 months ago (2016-06-15 23:00:27 UTC) #2
Andrew T Wilson (Slow)
lgtm https://codereview.chromium.org/2065343003/diff/20001/chrome/browser/chromeos/policy/remote_commands/device_command_reboot_job.h File chrome/browser/chromeos/policy/remote_commands/device_command_reboot_job.h (right): https://codereview.chromium.org/2065343003/diff/20001/chrome/browser/chromeos/policy/remote_commands/device_command_reboot_job.h#newcode33 chrome/browser/chromeos/policy/remote_commands/device_command_reboot_job.h:33: void TerminateImpl() override {} Let's leave this as ...
4 years, 6 months ago (2016-06-15 23:18:21 UTC) #3
Marton Hunyady
https://codereview.chromium.org/2065343003/diff/20001/chrome/browser/chromeos/policy/remote_commands/device_command_reboot_job.h File chrome/browser/chromeos/policy/remote_commands/device_command_reboot_job.h (right): https://codereview.chromium.org/2065343003/diff/20001/chrome/browser/chromeos/policy/remote_commands/device_command_reboot_job.h#newcode33 chrome/browser/chromeos/policy/remote_commands/device_command_reboot_job.h:33: void TerminateImpl() override {} On 2016/06/15 23:18:21, Andrew T ...
4 years, 6 months ago (2016-06-15 23:24:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2065343003/40001
4 years, 5 months ago (2016-06-29 08:00:47 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-06-29 09:16:38 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 09:18:07 UTC) #10
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/e36bafb7228006c262f219d0926345a39364de30
Cr-Commit-Position: refs/heads/master@{#402760}

Powered by Google App Engine
This is Rietveld 408576698