Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2065323004: [gn] Fix targets for x86 v8_target_arch (Closed)

Created:
4 years, 6 months ago by Michael Achenbach
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[gn] Fix targets for x86 v8_target_arch Those were wrongly translated from gyp with ia32. This should land before renaming v8_target_arch to v8_target_cpu. BUG=chromium:620527 NOTRY=true TBR=vogelheim@chromium.org Committed: https://crrev.com/acfff97cb7e7badbf0d5c597e4d75b467e71129b Cr-Commit-Position: refs/heads/master@{#37027}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M test/cctest/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
Michael Achenbach
PTAL
4 years, 6 months ago (2016-06-16 07:55:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065323004/1
4 years, 6 months ago (2016-06-16 08:02:53 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-16 08:04:15 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/acfff97cb7e7badbf0d5c597e4d75b467e71129b Cr-Commit-Position: refs/heads/master@{#37027}
4 years, 6 months ago (2016-06-16 08:07:03 UTC) #11
Dirk Pranke
4 years, 6 months ago (2016-06-16 17:51:32 UTC) #12
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698