Fix //net:test_support.

Fix //net:test_support.

Targets that depend on //net:test_support should be able to use
//net/data with no additional configuration.

BUG=

Committed: https://crrev.com/944eb92f25b35e52034e20609e5b040786ccc460
Cr-Commit-Position: refs/heads/master@{#400684}

[jbudorick, 2016-06-15 00:07:21]

Description was changed from

==========
wip: Fix //net:test_support.

BUG=
==========

to

==========
Fix //net:test_support.

Targets that depend on //net:test_support should be able to use
//net/data with no additional configuration.

BUG=
==========

[jbudorick, 2016-06-15 00:07:37]

Description was changed from

==========
Fix //net:test_support.

Targets that depend on //net:test_support should be able to use
//net/data with no additional configuration.

BUG=
==========

to

==========
Fix //net:test_support.

Targets that depend on //net:test_support should be able to use
//net/data with no additional configuration.

BUG=
==========

[jbudorick, 2016-06-15 13:42:56]

jbudorick@chromium.org changed reviewers:
+ rsleevi@chromium.org

[Ryan Sleevi, 2016-06-15 15:22:04]

I'm a little confused why extensions/remoting have it added to data_deps but the
other targets don't - I'm not sure which is necessary. Could you explain a
little more about that? This change LG otherwise, just wanting to make sure it's
intentional

https://codereview.chromium.org/2065313002/diff/40001/chrome/test/BUILD.gn
File chrome/test/BUILD.gn (right):

https://codereview.chromium.org/2065313002/diff/40001/chrome/test/BUILD.gn#ne...
chrome/test/BUILD.gn:336: data_deps = []
Do you know why //net:test_support doesn't need to be added here like it was for
remoting?

[jbudorick, 2016-06-15 15:37:29]

https://codereview.chromium.org/2065313002/diff/40001/chrome/test/BUILD.gn
File chrome/test/BUILD.gn (right):

https://codereview.chromium.org/2065313002/diff/40001/chrome/test/BUILD.gn#ne...
chrome/test/BUILD.gn:336: data_deps = []
On 2016/06/15 15:22:04, Ryan Sleevi wrote:
> Do you know why //net:test_support doesn't need to be added here like it was
for
> remoting?

Yeah, the targets to which I didn't add //net:test_support already have a
build-time dependency on //net:test_support in deps. The ones to which I did add
it don't have a similar build-time dependency and only use //net/data from the
target, which can be a run-time dependency in data_deps.

[Ryan Sleevi, 2016-06-15 15:47:19]

Ah LGTM then

[jbudorick, 2016-06-15 15:59:49]

jbudorick@chromium.org changed reviewers:
+ estark@chromium.org, phajdan.jr@chromium.org, rockot@chromium.org,
sergeyu@chromium.org

[jbudorick, 2016-06-15 15:59:50]

ptal for owners:
 - estark for components/security_state
 - phajdan.jr for chrome/test and content/test
 - rockot for extensions/
 - sergeyu for remoting/

[Ken Rockot(use gerrit already), 2016-06-15 16:06:54]

https://codereview.chromium.org/2065313002/diff/40001/extensions/BUILD.gn
File extensions/BUILD.gn (right):

https://codereview.chromium.org/2065313002/diff/40001/extensions/BUILD.gn#new...
extensions/BUILD.gn:249: "//net:test_support",
Shouldn't this be in deps, not data_deps?

[jbudorick, 2016-06-15 16:08:05]

https://codereview.chromium.org/2065313002/diff/40001/extensions/BUILD.gn
File extensions/BUILD.gn (right):

https://codereview.chromium.org/2065313002/diff/40001/extensions/BUILD.gn#new...
extensions/BUILD.gn:249: "//net:test_support",
On 2016/06/15 16:06:54, Ken Rockot wrote:
> Shouldn't this be in deps, not data_deps?

As it's only a run-time dependency, not a build-time one, I don't think so.

[Ken Rockot(use gerrit already), 2016-06-15 16:09:06]

On 2016/06/15 at 16:06:54, Ken Rockot wrote:
> https://codereview.chromium.org/2065313002/diff/40001/extensions/BUILD.gn
> File extensions/BUILD.gn (right):
> 
>
https://codereview.chromium.org/2065313002/diff/40001/extensions/BUILD.gn#new...
> extensions/BUILD.gn:249: "//net:test_support",
> Shouldn't this be in deps, not data_deps?

I see extensions_browsertests tests which use at least EmbeddedTestServer

[jbudorick, 2016-06-15 17:08:47]

On 2016/06/15 16:09:06, Ken Rockot wrote:
> On 2016/06/15 at 16:06:54, Ken Rockot wrote:
> > https://codereview.chromium.org/2065313002/diff/40001/extensions/BUILD.gn
> > File extensions/BUILD.gn (right):
> > 
> >
>
https://codereview.chromium.org/2065313002/diff/40001/extensions/BUILD.gn#new...
> > extensions/BUILD.gn:249: "//net:test_support",
> > Shouldn't this be in deps, not data_deps?
> 
> I see extensions_browsertests tests which use at least EmbeddedTestServer

Hm, so it does. Switched (and similarly updated //remoting)

[Ken Rockot(use gerrit already), 2016-06-15 17:10:17]

lgtm

[Sergey Ulanov, 2016-06-15 18:46:12]

lgtm

[estark, 2016-06-15 18:56:11]

components/security_state lgtm

[jbudorick, 2016-06-17 15:22:01]

phajdan.jr: ping

[jbudorick, 2016-06-20 10:19:23]

On 2016/06/17 15:22:01, jbudorick (EMEA til June 30) wrote:
> phajdan.jr: ping

pong

[Paweł Hajdan Jr., 2016-06-20 13:19:18]

LGTM

[jbudorick, 2016-06-20 13:20:54]

The CQ bit was checked by jbudorick@chromium.org

[jbudorick, 2016-06-20 13:20:55]

The patchset sent to the CQ was uploaded after l-g-t-m from rsleevi@chromium.org
Link to the patchset: https://codereview.chromium.org/2065313002/#ps60001
(title: "rockot comments")

[commit-bot: I haz the power, 2016-06-20 13:21:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2065313002/60001

[commit-bot: I haz the power, 2016-06-20 13:22:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-20 13:22:45]

Try jobs failed on following builders:
  ios-device on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[jbudorick, 2016-06-20 14:08:38]

The CQ bit was checked by jbudorick@chromium.org

[jbudorick, 2016-06-20 14:08:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
sergeyu@chromium.org, rockot@chromium.org, phajdan.jr@chromium.org,
rsleevi@chromium.org, estark@chromium.org
Link to the patchset: https://codereview.chromium.org/2065313002/#ps100001
(title: "rebase")

[commit-bot: I haz the power, 2016-06-20 14:09:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2065313002/100001

[commit-bot: I haz the power, 2016-06-20 15:38:47]

Description was changed from

==========
Fix //net:test_support.

Targets that depend on //net:test_support should be able to use
//net/data with no additional configuration.

BUG=
==========

to

==========
Fix //net:test_support.

Targets that depend on //net:test_support should be able to use
//net/data with no additional configuration.

BUG=
==========

[commit-bot: I haz the power, 2016-06-20 15:38:49]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-06-20 15:40:22]

Description was changed from

==========
Fix //net:test_support.

Targets that depend on //net:test_support should be able to use
//net/data with no additional configuration.

BUG=
==========

to

==========
Fix //net:test_support.

Targets that depend on //net:test_support should be able to use
//net/data with no additional configuration.

BUG=

Committed: https://crrev.com/944eb92f25b35e52034e20609e5b040786ccc460
Cr-Commit-Position: refs/heads/master@{#400684}
==========

[commit-bot: I haz the power, 2016-06-20 15:40:23]

Patchset 6 (id:??) landed as
https://crrev.com/944eb92f25b35e52034e20609e5b040786ccc460
Cr-Commit-Position: refs/heads/master@{#400684}