third_party/WebKit/Source/core/layout/LayoutBox.cpp - Issue 2065243003: [css-sizing] Ensure positive available size on replaced elements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBox.cpp

Issue 2065243003: [css-sizing] Ensure positive available size on replaced elements Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebaselined test. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css-intrinsic-dimensions/fit-content-min-width-with-zero-width-container-should-not-crash.html ('k') | third_party/WebKit/Source/core/layout/LayoutReplaced.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutBox.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.cpp b/third_party/WebKit/Source/core/layout/LayoutBox.cpp

index 3ad08c2f8690a0b53c26c12ddbb85d11157304f1..0bf81671d453f097ea087df6c0847636509b4e3f 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBox.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutBox.cpp

@@ -3269,14 +3269,15 @@ LayoutUnit LayoutBox::computeReplacedLogicalWidth(

LayoutUnit LayoutBox::computeReplacedLogicalWidthRespectingMinMaxWidth(

LayoutUnit logicalWidth,

ShouldComputePreferred shouldComputePreferred) const {

- LayoutUnit minLogicalWidth = (shouldComputePreferred == ComputePreferred &&

- style()->logicalMinWidth().isPercentOrCalc())

- ? logicalWidth

- : computeReplacedLogicalWidthUsing(

- MinSize, style()->logicalMinWidth());

+ LayoutUnit minLogicalWidth =

+ shouldComputePreferred == ComputePreferred &&

+ style()->logicalMinWidth().isLayoutDependent()

+ ? logicalWidth

+ : computeReplacedLogicalWidthUsing(MinSize,

+ style()->logicalMinWidth());

LayoutUnit maxLogicalWidth =

(shouldComputePreferred == ComputePreferred &&

- style()->logicalMaxWidth().isPercentOrCalc()) ||

+ style()->logicalMaxWidth().isLayoutDependent()) ||

style()->logicalMaxWidth().isMaxSizeNone()

? logicalWidth

: computeReplacedLogicalWidthUsing(MaxSize,