Force flattening for elements with non-initial value of opacity

third_party/WebKit/Source/core/style/ComputedStyle.h

Index: third_party/WebKit/Source/core/style/ComputedStyle.h
diff --git a/third_party/WebKit/Source/core/style/ComputedStyle.h b/third_party/WebKit/Source/core/style/ComputedStyle.h
index 5fcda23f6e5c1630ac1fab03817ed21f1bdbe3d9..2ca45cb86bf63c671fb93fa6e8714d32025d5581 100644
--- a/third_party/WebKit/Source/core/style/ComputedStyle.h
+++ b/third_party/WebKit/Source/core/style/ComputedStyle.h
@@ -457,6 +457,17 @@ public:
     // used (including, but not limited to, 'filter').
     bool hasFilterInducingProperty() const { return hasFilter() || (RuntimeEnabledFeatures::cssBoxReflectFilterEnabled() && hasBoxReflect()); }
 
+    // Returns |true| if opacity should be considered to have non-initial value for the purpose
+    // of creating stacking contexts.
+    bool hasNonInitialOpacity() const { return opacity() != 1.0f || hasWillChangeOpacityHint() || hasCurrentOpacityAnimation(); }

[chrishtr, 2016/06/15 16:06:41]

hasOpacity() is the way to check for inequality with 1.0.

Also, do hasWillChangeOpacityHint() or hasCurrentOpacityAnimation() cause
stacking contexts in the code right now?

[trchen, 2016/06/18 00:27:09]

Done.
Yes for will-change:opacity.

No for opacity animation (on the frame that opacity happens to be 1.0). I think
it is a bug but isn't really important.

+
+    // Returns whether this style contains any grouping property as defined by [css-transforms].
+    // The main purpose of this is to adjust the used value of transform-style property.
+    // Note: We currently don't include every grouping property on the spec to maintain
+    //       backward compatibility.
+    // [css-transforms] https://drafts.csswg.org/css-transforms/#grouping-property-values
+    bool hasGroupingProperty() const { return !isOverflowVisible() || hasFilterInducingProperty() || hasNonInitialOpacity(); }
+
     Order rtlOrdering() const { return static_cast<Order>(inherited_flags.m_rtlOrdering); }
     void setRTLOrdering(Order o) { inherited_flags.m_rtlOrdering = o; }
 
@@ -959,7 +970,8 @@ public:
     CSSTransitionData& accessTransitions();
 
     ETransformStyle3D transformStyle3D() const { return static_cast<ETransformStyle3D>(rareNonInheritedData->m_transformStyle3D); }
-    bool preserves3D() const { return rareNonInheritedData->m_transformStyle3D == TransformStyle3DPreserve3D; }
+    ETransformStyle3D usedTransformStyle3D() const;
+    bool preserves3D() const { return usedTransformStyle3D() != TransformStyle3DFlat; }
 
     EBackfaceVisibility backfaceVisibility() const { return static_cast<EBackfaceVisibility>(rareNonInheritedData->m_backfaceVisibility); }
     float perspective() const { return rareNonInheritedData->m_perspective; }
@@ -1027,6 +1039,7 @@ public:
     bool willChangeContents() const { return rareNonInheritedData->m_willChange->m_contents; }
     bool willChangeScrollPosition() const { return rareNonInheritedData->m_willChange->m_scrollPosition; }
     bool hasWillChangeCompositingHint() const;
+    bool hasWillChangeOpacityHint() const { return willChangeProperties().contains(CSSPropertyOpacity); }
     bool hasWillChangeTransformHint() const;
     bool subtreeWillChangeContents() const { return rareInheritedData->m_subtreeWillChangeContents; }