third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp - Issue 2065233002: Force flattening for elements with non-initial value of opacity

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp

Issue 2065233002: Force flattening for elements with non-initial value of opacity (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/transforms/opacity-forces-flatten-expected.html ('k') | third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp » ('j') | third_party/WebKit/Source/core/style/ComputedStyle.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp

diff --git a/third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp b/third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp

index 5d363848d3c5ab03df6601b0635173eddeff537e..29619769f1d150883ea9ad5c623c15d4d67f58f8 100644

--- a/third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp

+++ b/third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp

@@ -221,12 +221,6 @@ void StyleAdjuster::adjustComputedStyle(ComputedStyle& style, const ComputedStyl

if (style.hasPseudoStyle(PseudoIdFirstLetter) || style.transitions() || style.animations())

style.setUnique();

- // FIXME: when dropping the -webkit prefix on transform-style, we should also have opacity < 1 cause flattening.

- if (style.preserves3D() && (style.overflowX() != OverflowVisible

- || style.overflowY() != OverflowVisible

- || style.hasFilterInducingProperty()))

- style.setTransformStyle3D(TransformStyle3DFlat);

adjustStyleForEditing(style);

bool isSVGElement = element && element->isSVGElement();