Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2065213002:
Upgrade testing_support library (Closed)
|
Created:
4 years, 6 months ago by Sergiy Byelozyorov Modified:
4 years, 5 months ago CC:
chromium-reviews, infra-reviews+infra_chromium.org Base URL:
https://chromium.googlesource.com/infra/infra.git@master Target Ref:
refs/heads/master Project:
infra Visibility:
Public. |
DescriptionUpgrade testing_support library
This is to roll thread_watcher into infra and infra_internal: https://codereview.chromium.org/2067533002/.
R=tandrii@chromium.org
BUG=619481
Committed: https://chromium.googlesource.com/infra/infra/+/9d0fd099f608eb34264fc209e8b1e9960a0bddcc
Patch Set 1 #
Messages
Total messages: 23 (11 generated)
The CQ bit was checked by sergiyb@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065213002/1
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Infra Presubmit on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Infra%20Presubmit/build...) Infra Win Tester on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Infra%20Win%20Tester/bu...)
The CQ bit was checked by sergiyb@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065213002/1
Description was changed from ========== Upgrade testing_support library R=tandrii@chromium.org BUG=619481 ========== to ========== Upgrade testing_support library This is to roll ThreadWatcher into infra and infra_internal: https://codereview.chromium.org/2067533002/. R=tandrii@chromium.org BUG=619481 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Exceeded global retry quota
The CQ bit was checked by sergiyb@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065213002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by sergiyb@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065213002/1
Description was changed from ========== Upgrade testing_support library This is to roll ThreadWatcher into infra and infra_internal: https://codereview.chromium.org/2067533002/. R=tandrii@chromium.org BUG=619481 ========== to ========== Upgrade testing_support library This is to roll thread_watcher into infra and infra_internal: https://codereview.chromium.org/2067533002/. R=tandrii@chromium.org BUG=619481 ==========
Message was sent while issue was closed.
Description was changed from ========== Upgrade testing_support library This is to roll thread_watcher into infra and infra_internal: https://codereview.chromium.org/2067533002/. R=tandrii@chromium.org BUG=619481 ========== to ========== Upgrade testing_support library This is to roll thread_watcher into infra and infra_internal: https://codereview.chromium.org/2067533002/. R=tandrii@chromium.org BUG=619481 Committed: https://chromium.googlesource.com/infra/infra/+/9d0fd099f608eb34264fc209e8b1e... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/infra/infra/+/9d0fd099f608eb34264fc209e8b1e...
Message was sent while issue was closed.
nodir@chromium.org changed reviewers: + nodir@chromium.org
Message was sent while issue was closed.
looking at build results (if you click "More>>>") tests became very flaky. Am I missing something?
Message was sent while issue was closed.
On 2016/06/26 07:31:01, nodir wrote: > looking at build results (if you click "More>>>") tests became very flaky. Am I > missing something? perhaps I missed https://codereview.chromium.org/2063293002
Message was sent while issue was closed.
On 2016/06/26 08:06:42, nodir wrote: > On 2016/06/26 07:31:01, nodir wrote: > > looking at build results (if you click "More>>>") tests became very flaky. Am > I > > missing something? > > perhaps I missed https://codereview.chromium.org/2063293002 IIRC, tests were flaky before this CL as well and I fixed them in the CL you referenced. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
