[Devil] Run devil real device tests on android devices when available.

[Devil] Run devil real device tests on android devices when available.

BUG=chromium:619068
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/48413bae81d72eb92ddcbf98b606d18124de84be

[rnephew (Reviews Here), 2016-06-14 18:15:27]

rnephew@chromium.org changed reviewers:
+ jbudorick@chromium.org, nednguyen@google.com, sullivan@chromium.org

[jbudorick, 2016-06-14 18:17:23]

https://codereview.chromium.org/2065163002/diff/1/catapult_build/build_steps.py
File catapult_build/build_steps.py (right):

https://codereview.chromium.org/2065163002/diff/1/catapult_build/build_steps....
catapult_build/build_steps.py:186: 'name': 'Android: Devil Device Tests',
Move this up w/ the Devil Python Tests & drop the "Android: " from the name
here.

[jbudorick, 2016-06-14 18:17:35]

(non-owner lgtm w/ nits)

On 2016/06/14 18:17:23, jbudorick wrote:
>
https://codereview.chromium.org/2065163002/diff/1/catapult_build/build_steps.py
> File catapult_build/build_steps.py (right):
> 
>
https://codereview.chromium.org/2065163002/diff/1/catapult_build/build_steps....
> catapult_build/build_steps.py:186: 'name': 'Android: Devil Device Tests',
> Move this up w/ the Devil Python Tests & drop the "Android: " from the name
> here.

[nednguyen, 2016-06-14 18:18:51]

lgtm
Awesome, I hope we can start to write more "actual tests" :-)

[rnephew (Reviews Here), 2016-06-14 18:25:41]

On 2016/06/14 18:18:51, nednguyen wrote:
> lgtm
> Awesome, I hope we can start to write more "actual tests" :-)

Failed because of path issue. Added devil to path in __init__. PTAL.

[rnephew (Reviews Here), 2016-06-14 18:26:43]

Patchset #3 (id:40001) has been deleted

[rnephew (Reviews Here), 2016-06-14 18:31:16]

Patchset #3 (id:60001) has been deleted

[nednguyen, 2016-06-14 18:34:47]

https://codereview.chromium.org/2065163002/diff/80001/catapult_build/__init__.py
File catapult_build/__init__.py (right):

https://codereview.chromium.org/2065163002/diff/80001/catapult_build/__init__...
catapult_build/__init__.py:29: _AddToPathIfNeeded(os.path.join(catapult_path,
'devil'))
Hmhh, this seems wrong. Are we using any module in devil in catapult_build/?

[rnephew (Reviews Here), 2016-06-14 18:35:56]

On 2016/06/14 18:34:47, nednguyen wrote:
>
https://codereview.chromium.org/2065163002/diff/80001/catapult_build/__init__.py
> File catapult_build/__init__.py (right):
> 
>
https://codereview.chromium.org/2065163002/diff/80001/catapult_build/__init__...
> catapult_build/__init__.py:29: _AddToPathIfNeeded(os.path.join(catapult_path,
> 'devil'))
> Hmhh, this seems wrong. Are we using any module in devil in catapult_build/?

I can get rid of that line, the real fix was in device_utils_devicetest.py
itself.

[jbudorick, 2016-06-14 21:12:11]

devil/ lgtm

[rnephew (Reviews Here), 2016-06-14 21:12:32]

The CQ bit was checked by rnephew@chromium.org

[rnephew (Reviews Here), 2016-06-14 21:12:32]

The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com
Link to the patchset: https://codereview.chromium.org/2065163002/#ps120001
(title: " ")

[commit-bot: I haz the power, 2016-06-14 21:12:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2065163002/120001

[commit-bot: I haz the power, 2016-06-14 21:39:34]

Description was changed from

==========
[Devil] Run devil real device tests on android devices when available.

BUG=chromium:619068
==========

to

==========
[Devil] Run devil real device tests on android devices when available.

BUG=chromium:619068

Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2016-06-14 21:39:35]

Committed patchset #5 (id:120001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...