exo: Implement notification surface support

components/exo/display.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/exo/display.h"
 
 #include <iterator>
 #include <utility>
 
 #include "ash/common/shell_window_ids.h"
 #include "base/command_line.h"
 #include "base/memory/ptr_util.h"
 #include "base/trace_event/trace_event.h"
 #include "base/trace_event/trace_event_argument.h"
+#include "components/exo/notification_surface.h"
+#include "components/exo/notification_surface_manager.h"
 #include "components/exo/shared_memory.h"
 #include "components/exo/shell_surface.h"
 #include "components/exo/sub_surface.h"
 #include "components/exo/surface.h"
 #include "ui/views/widget/widget.h"
 
 #if defined(USE_OZONE)
 #include <GLES2/gl2extchromium.h>
 #include "components/exo/buffer.h"
 #include "gpu/command_buffer/client/gpu_memory_buffer_manager.h"
@@ skipping 147 matching lines @@
   }
 
   if (surface->HasSurfaceDelegate()) {
     DLOG(ERROR) << "Surface has already been assigned a role";
     return nullptr;
   }
 
   return base::WrapUnique(new SubSurface(surface, parent));
 }
 
+std::unique_ptr<NotificationSurface> Display::CreateNotificationSurface(
+    Surface* surface,
+    const std::string& notification_id) {
+  TRACE_EVENT2("exo", "Display::CreateNotificationSurface", "surface",
+               surface->AsTracedValue(), "notification_id", notification_id);
+
+  if (notification_surface_manager_ &&

[reveman, 2016/06/23 16:34:52]

nit: please fail if "!notification_surface_manager_" instead of having do deal
with that in the notification surface impl

[xiyuan, 2016/06/23 17:46:09]

Done.

+      notification_surface_manager_->GetSurface(notification_id) != nullptr) {

[reveman, 2016/06/23 16:34:52]

nit: s/GetSurface(notification_id) != nullptr/GetSurface(notification_id)/

[xiyuan, 2016/06/23 17:46:09]

Done.

+    DLOG(ERROR) << "Invalid notification id, id=" << notification_id;
+    return nullptr;
+  }
+
+  return base::WrapUnique(new NotificationSurface(
+      notification_surface_manager_.get(), surface, notification_id));
+}
+
+void Display::SetNotificationSurfaceManager(
+    std::unique_ptr<NotificationSurfaceManager> notification_surface_manager) {
+  notification_surface_manager_ = std::move(notification_surface_manager);
+}
+
 }  // namespace exo