Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 206513005: [ChromeOS] Disable PrefHash browser tests on ChromeOS (Closed)

Created:
6 years, 9 months ago by oshima
Modified:
6 years, 9 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

[ChromeOS] Disable PrefHash browser tests because PrefHash service has been disabled on ChromeOS BUG=351251 TBR=bauerb@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260258

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -3 lines) Patch
M chrome/browser/prefs/pref_hash_browsertest.cc View 1 3 chunks +14 lines, -3 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
oshima
6 years, 9 months ago (2014-03-21 00:06:52 UTC) #1
Dmitry Polukhin
LGTM but I would wait for review from someone familiar with PrefHash and long term ...
6 years, 9 months ago (2014-03-21 00:19:09 UTC) #2
oshima
On 2014/03/21 00:19:09, Dmitry Polukhin wrote: > LGTM but I would wait for review from ...
6 years, 9 months ago (2014-03-21 01:59:47 UTC) #3
oshima
erikwright@, ping?
6 years, 9 months ago (2014-03-22 00:52:03 UTC) #4
erikwright (departed)
LGTM
6 years, 9 months ago (2014-03-25 13:48:43 UTC) #5
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 9 months ago (2014-03-25 14:55:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/206513005/40001
6 years, 9 months ago (2014-03-25 14:55:25 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-25 15:29:26 UTC) #8
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=57260
6 years, 9 months ago (2014-03-25 15:29:27 UTC) #9
oshima
+pam -> owners review
6 years, 9 months ago (2014-03-25 15:35:00 UTC) #10
oshima
bauerb@, can you stamp this CL?
6 years, 9 months ago (2014-03-27 16:59:32 UTC) #11
oshima
bauerb@, I'm tbring because this is just disabling test. let me know if you have ...
6 years, 9 months ago (2014-03-28 16:31:09 UTC) #12
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 9 months ago (2014-03-28 16:31:13 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/206513005/40001
6 years, 9 months ago (2014-03-28 16:31:36 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 17:20:27 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_rel
6 years, 9 months ago (2014-03-28 17:20:27 UTC) #16
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 9 months ago (2014-03-28 17:47:30 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/206513005/200001
6 years, 9 months ago (2014-03-28 17:50:29 UTC) #18
commit-bot: I haz the power
6 years, 9 months ago (2014-03-28 20:20:29 UTC) #19
Message was sent while issue was closed.
Change committed as 260258

Powered by Google App Engine
This is Rietveld 408576698