Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 206513004: Support invalidation sets for shadow combinators. (Closed)

Created:
6 years, 9 months ago by rune
Modified:
6 years, 9 months ago
Reviewers:
chrishtr, esprehn
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, dglazkov+blink, ed+blinkwatch_opera.com, rwlbuis, rune+blink
Visibility:
Public.

Description

Support invalidation sets for shadow combinators. We bailed out of invalidation set support for selectors containing /shadow/ or /shadow-deep/. For invalidation sets they now work like descendant/child combinators do. R=esprehn@chromium.org, chrishtr@chromium.org BUG=335247 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169706

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -1 line) Patch
A LayoutTests/fast/css/invalidation/targeted-class-shadow-combinator.html View 1 chunk +48 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/invalidation/targeted-class-shadow-combinator-expected.txt View 1 chunk +15 lines, -0 lines 0 comments Download
M Source/core/css/RuleFeature.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
rune
6 years, 9 months ago (2014-03-20 20:46:18 UTC) #1
esprehn
lgtm
6 years, 9 months ago (2014-03-20 20:52:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/206513004/1
6 years, 9 months ago (2014-03-20 20:53:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/206513004/1
6 years, 9 months ago (2014-03-20 21:56:22 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-03-20 23:04:51 UTC) #5
Message was sent while issue was closed.
Change committed as 169706

Powered by Google App Engine
This is Rietveld 408576698