Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 206513003: Make droger an owner of Translate (Closed)

Created:
6 years, 9 months ago by droger
Modified:
6 years, 9 months ago
Reviewers:
MAD, blundell
CC:
chromium-reviews, hajimehoshi, Takashi Toyoshima, blundell
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M chrome/browser/translate/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/translate/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/translate/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M components/OWNERS View 2 chunks +2 lines, -1 line 0 comments Download
M components/language_usage_metrics/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M components/translate/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
droger
As discussed with mad, this is for now a temporary ownership to complete the componentization. ...
6 years, 9 months ago (2014-03-20 15:58:51 UTC) #1
MAD
lgtm
6 years, 9 months ago (2014-03-20 16:07:37 UTC) #2
droger
The CQ bit was checked by droger@chromium.org
6 years, 9 months ago (2014-03-20 16:26:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/droger@chromium.org/206513003/1
6 years, 9 months ago (2014-03-20 16:28:01 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-20 17:07:53 UTC) #5
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=56476
6 years, 9 months ago (2014-03-20 17:07:53 UTC) #6
droger
blundell: can you do a OWNER review for components/?
6 years, 9 months ago (2014-03-20 17:09:03 UTC) #7
blundell
LGTM
6 years, 9 months ago (2014-03-20 17:14:42 UTC) #8
droger
6 years, 9 months ago (2014-03-20 18:17:15 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 manually as r258351 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698