Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: src/code-stub-assembler.h

Issue 2065113002: [ic] LoadGlobalIC caches PropertyCells in the feedback vector. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebasing Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/builtins.h ('k') | src/code-stub-assembler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/code-stub-assembler.h
diff --git a/src/code-stub-assembler.h b/src/code-stub-assembler.h
index acafb6a8af6fb7a3d27a32350ac17fe9310e68b6..9585436c71d8b9ed11bea0f9b4c2a06f9e9af1c1 100644
--- a/src/code-stub-assembler.h
+++ b/src/code-stub-assembler.h
@@ -123,6 +123,8 @@ class CodeStubAssembler : public compiler::CodeAssembler {
compiler::Node* LoadMap(compiler::Node* object);
// Load the instance type of an HeapObject.
compiler::Node* LoadInstanceType(compiler::Node* object);
+ // Checks that given heap object has given instance type.
+ void AssertInstanceType(compiler::Node* object, InstanceType instance_type);
// Load the properties backing store of a JSObject.
compiler::Node* LoadProperties(compiler::Node* object);
// Load the elements backing store of a JSObject.
@@ -156,7 +158,8 @@ class CodeStubAssembler : public compiler::CodeAssembler {
// Load value field of a JSValue object.
compiler::Node* LoadJSValueValue(compiler::Node* object);
// Load value field of a WeakCell object.
- compiler::Node* LoadWeakCellValue(compiler::Node* weak_cell);
+ compiler::Node* LoadWeakCellValue(compiler::Node* weak_cell,
+ Label* if_cleared = nullptr);
compiler::Node* AllocateUninitializedFixedArray(compiler::Node* length);
@@ -352,7 +355,8 @@ class CodeStubAssembler : public compiler::CodeAssembler {
Label* if_handler, Variable* var_handler,
Label* if_miss);
- void LoadIC(const LoadICParameters* p, Label* if_miss);
+ void LoadIC(const LoadICParameters* p);
+ void LoadGlobalIC(const LoadICParameters* p);
private:
compiler::Node* ElementOffsetFromIndex(compiler::Node* index,
« no previous file with comments | « src/builtins.h ('k') | src/code-stub-assembler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698