Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 20651004: rAc: add Google Wallet logo to bottom left. (Closed)

Created:
7 years, 4 months ago by Evan Stade
Modified:
7 years, 4 months ago
Reviewers:
groby-ooo-7-16
CC:
chromium-reviews, Raman Kakilate, oshima+watch_chromium.org, benquan, tfarina, ahutter, Dane Wallinga, dyu1, estade+watch_chromium.org, Albert Bodenhamer, Ilya Sherman, rouslan+autofillwatch_chromium.org
Visibility:
Public.

Description

rAc: add Google Wallet logo to bottom left. BUG=258563 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215765

Patch Set 1 #

Patch Set 2 : update comment #

Patch Set 3 : synced #

Patch Set 4 : MockAutofillDialogController update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -12 lines) Patch
M chrome/browser/ui/autofill/autofill_dialog_controller.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/ui/autofill/mock_autofill_dialog_controller.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/autofill/autofill_dialog_views.h View 1 2 3 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/autofill/autofill_dialog_views.cc View 1 2 3 7 chunks +15 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Evan Stade
assets to be added in https://codereview.chromium.org/20726007/
7 years, 4 months ago (2013-08-01 22:26:43 UTC) #1
Evan Stade
ping before you leave
7 years, 4 months ago (2013-08-02 21:45:33 UTC) #2
groby-ooo-7-16
lgtm
7 years, 4 months ago (2013-08-02 22:03:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/20651004/11001
7 years, 4 months ago (2013-08-02 22:14:06 UTC) #4
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 4 months ago (2013-08-02 22:55:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/20651004/31001
7 years, 4 months ago (2013-08-05 20:37:29 UTC) #6
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 4 months ago (2013-08-05 20:48:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/20651004/31001
7 years, 4 months ago (2013-08-05 23:04:08 UTC) #8
commit-bot: I haz the power
7 years, 4 months ago (2013-08-06 02:39:56 UTC) #9
Message was sent while issue was closed.
Change committed as 215765

Powered by Google App Engine
This is Rietveld 408576698