Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 2065093002: Reland of "Remove redundant "layout size changed" state from LayoutSVGRoot" (Closed)

Created:
4 years, 6 months ago by fs
Modified:
4 years, 6 months ago
Reviewers:
pdr., Stephen Chennney
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, krit, eae+blinkwatch, f(malita), gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of "Remove redundant "layout size changed" state from LayoutSVGRoot" In LayoutSVGRoot::layout, two slightly different "layout size changed" values are computed - one which is used for propagation to children via SVGLayoutSupport::layoutSizeOfNearestViewportChanged (|m_isLayoutSizeChanged|), and one which is used to mark direct descendant children (local |layoutSizeChanged|). Ultimately their use is the same though, so only using the more narrow predicate for both of these cases should yield the same result. It also has the side-effect of making it more obvious that changes to layout-size is only of interest when there exist clients of the SVG root that have relative lengths. BUG=603956 Committed: https://crrev.com/2fd756f78f5d05f69bd298515bb7eff07f500b6a Cr-Commit-Position: refs/heads/master@{#400987}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp View 1 chunk +2 lines, -3 lines 2 comments Download

Messages

Total messages: 28 (12 generated)
fs
4 years, 6 months ago (2016-06-14 18:40:39 UTC) #3
Stephen Chennney
lgtm https://codereview.chromium.org/2065093002/diff/1/third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp File third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp (right): https://codereview.chromium.org/2065093002/diff/1/third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp#newcode158 third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp:158: m_isLayoutSizeChanged = svg->hasRelativeLengths() && (selfNeedsLayout() || oldSize != ...
4 years, 6 months ago (2016-06-14 20:34:58 UTC) #5
fs
https://codereview.chromium.org/2065093002/diff/1/third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp File third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp (right): https://codereview.chromium.org/2065093002/diff/1/third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp#newcode158 third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp:158: m_isLayoutSizeChanged = svg->hasRelativeLengths() && (selfNeedsLayout() || oldSize != size()); ...
4 years, 6 months ago (2016-06-14 20:46:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065093002/1
4 years, 6 months ago (2016-06-14 20:47:41 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-14 21:48:33 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-14 21:48:55 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/30770a70834c73670884f0de91bb7624df0ba003 Cr-Commit-Position: refs/heads/master@{#399791}
4 years, 6 months ago (2016-06-14 21:50:05 UTC) #12
fs
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2071953004/ by fs@opera.com. ...
4 years, 6 months ago (2016-06-17 07:34:22 UTC) #13
fs
On 2016/06/17 at 07:34:22, fs wrote: > A revert of this CL (patchset #1 id:1) ...
4 years, 6 months ago (2016-06-20 11:17:04 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065093002/1
4 years, 6 months ago (2016-06-20 11:17:24 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/241567)
4 years, 6 months ago (2016-06-20 13:18:17 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065093002/1
4 years, 6 months ago (2016-06-20 13:23:35 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/241633)
4 years, 6 months ago (2016-06-20 14:54:03 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065093002/1
4 years, 6 months ago (2016-06-21 13:17:49 UTC) #25
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-21 14:29:10 UTC) #26
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 14:34:20 UTC) #28
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2fd756f78f5d05f69bd298515bb7eff07f500b6a
Cr-Commit-Position: refs/heads/master@{#400987}

Powered by Google App Engine
This is Rietveld 408576698